Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2498053002: Add field to monitor last visited time for each search engine (Closed)

Created:
4 years, 1 month ago by ltian
Modified:
4 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, extensions-reviews_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add field to monitor last visited time for each search engine 1. Add the last_visited field in template_url_data to monitor last visited time of each search engine. 2. The last_visited will be updated to current time each time the OpenSearch description document is detected. 3. For now, last_visited will not be synced if the template_url is existed. BUG=348360 Committed: https://crrev.com/8b5fc83dba9f525b0f707433a9fbb91465ca9bdd Cr-Commit-Position: refs/heads/master@{#436079}

Patch Set 1 #

Patch Set 2 : Add unit test for last_visited field. #

Total comments: 67

Patch Set 3 : Update based on Peter's comments. #

Patch Set 4 : Gclient sync and fix patch failure caused by conflicts. #

Patch Set 5 : Remove sync operations of last_visited field. #

Total comments: 19

Patch Set 6 : Update based on Peter's comments. #

Patch Set 7 : Add comment. #

Total comments: 1

Patch Set 8 : Update Nit comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -110 lines) Patch
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 2 3 4 5 29 chunks +99 lines, -65 lines 0 comments Download
M components/search_engines/default_search_manager.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/search_engines/default_search_manager.cc View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M components/search_engines/default_search_manager_unittest.cc View 1 2 3 4 5 3 chunks +4 lines, -2 lines 0 comments Download
M components/search_engines/keyword_table.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/search_engines/keyword_table.cc View 1 2 8 chunks +41 lines, -27 lines 0 comments Download
M components/search_engines/keyword_table_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/search_engines/template_url.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/search_engines/template_url_data.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M components/search_engines/template_url_data.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/search_engines/template_url_data_util.cc View 1 2 3 4 5 2 chunks +11 lines, -4 lines 0 comments Download
M components/search_engines/template_url_service.h View 1 2 3 4 5 6 7 3 chunks +8 lines, -0 lines 0 comments Download
M components/search_engines/template_url_service.cc View 1 2 3 4 5 6 8 chunks +26 lines, -9 lines 0 comments Download
A components/test/data/web_database/version_68.sql View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M components/webdata/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/webdata/common/web_database.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 1 2 4 chunks +35 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 55 (37 generated)
ltian
Please review the changes. Thanks!
4 years, 1 month ago (2016-11-17 23:23:34 UTC) #10
Peter Kasting
https://codereview.chromium.org/2498053002/diff/20001/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc File chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc (right): https://codereview.chromium.org/2498053002/diff/20001/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc#newcode115 chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc:115: data->last_visited = base::Time(); I don't really understand why |date_created| ...
4 years, 1 month ago (2016-11-21 03:35:09 UTC) #11
ltian
https://codereview.chromium.org/2498053002/diff/20001/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc File chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc (right): https://codereview.chromium.org/2498053002/diff/20001/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc#newcode115 chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc:115: data->last_visited = base::Time(); On 2016/11/21 03:35:07, Peter Kasting wrote: ...
4 years ago (2016-11-28 22:08:03 UTC) #20
Peter Kasting
https://codereview.chromium.org/2498053002/diff/20001/components/search_engines/template_url_service.cc File components/search_engines/template_url_service.cc (right): https://codereview.chromium.org/2498053002/diff/20001/components/search_engines/template_url_service.cc#newcode731 components/search_engines/template_url_service.cc:731: NotifyObservers(); On 2016/11/28 22:08:02, ltian wrote: > On 2016/11/21 ...
4 years ago (2016-11-28 22:20:24 UTC) #21
ltian
https://codereview.chromium.org/2498053002/diff/20001/components/search_engines/template_url_service.cc File components/search_engines/template_url_service.cc (right): https://codereview.chromium.org/2498053002/diff/20001/components/search_engines/template_url_service.cc#newcode731 components/search_engines/template_url_service.cc:731: NotifyObservers(); On 2016/11/28 22:20:24, Peter Kasting wrote: > On ...
4 years ago (2016-11-30 00:22:18 UTC) #22
Peter Kasting
https://codereview.chromium.org/2498053002/diff/20001/components/search_engines/template_url_service.cc File components/search_engines/template_url_service.cc (right): https://codereview.chromium.org/2498053002/diff/20001/components/search_engines/template_url_service.cc#newcode731 components/search_engines/template_url_service.cc:731: NotifyObservers(); On 2016/11/30 00:22:18, ltian wrote: > On 2016/11/28 ...
4 years ago (2016-11-30 00:39:37 UTC) #23
ltian
4 years ago (2016-11-30 06:35:58 UTC) #30
Peter Kasting
https://codereview.chromium.org/2498053002/diff/20001/chrome/browser/search_engines/template_url_service_unittest.cc File chrome/browser/search_engines/template_url_service_unittest.cc (right): https://codereview.chromium.org/2498053002/diff/20001/chrome/browser/search_engines/template_url_service_unittest.cc#newcode1546 chrome/browser/search_engines/template_url_service_unittest.cc:1546: TemplateURL* modified_url = model()->GetTemplateURLForKeyword( On 2016/11/28 22:08:01, ltian wrote: ...
4 years ago (2016-12-01 07:38:25 UTC) #33
ltian
https://codereview.chromium.org/2498053002/diff/80001/components/search_engines/default_search_manager_unittest.cc File components/search_engines/default_search_manager_unittest.cc (right): https://codereview.chromium.org/2498053002/diff/80001/components/search_engines/default_search_manager_unittest.cc#newcode32 components/search_engines/default_search_manager_unittest.cc:32: // Checks that the two TemplateURLs are similar. Does ...
4 years ago (2016-12-01 10:02:59 UTC) #38
Peter Kasting
https://codereview.chromium.org/2498053002/diff/80001/components/search_engines/template_url_service.cc File components/search_engines/template_url_service.cc (right): https://codereview.chromium.org/2498053002/diff/80001/components/search_engines/template_url_service.cc#newcode1806 components/search_engines/template_url_service.cc:1806: visited_url = *i; On 2016/12/01 10:02:58, ltian wrote: > ...
4 years ago (2016-12-01 19:32:35 UTC) #39
Peter Kasting
On 2016/12/01 19:32:35, Peter Kasting wrote: > This can be fixed in a way that ...
4 years ago (2016-12-02 02:07:33 UTC) #40
ltian
On 2016/12/02 02:07:33, Peter Kasting wrote: > On 2016/12/01 19:32:35, Peter Kasting wrote: > > ...
4 years ago (2016-12-02 02:23:28 UTC) #41
Peter Kasting
On 2016/12/02 02:23:28, ltian wrote: > For this CL, I prefer keeping with my current ...
4 years ago (2016-12-02 02:25:38 UTC) #42
ltian
4 years ago (2016-12-02 02:59:39 UTC) #43
Peter Kasting
LGTM https://codereview.chromium.org/2498053002/diff/120001/components/search_engines/template_url_service.h File components/search_engines/template_url_service.h (right): https://codereview.chromium.org/2498053002/diff/120001/components/search_engines/template_url_service.h#newcode572 components/search_engines/template_url_service.h:572: // Updates the last_visited time of TemplateURL to ...
4 years ago (2016-12-02 21:31:13 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498053002/140001
4 years ago (2016-12-02 23:34:22 UTC) #51
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years ago (2016-12-02 23:44:08 UTC) #53
commit-bot: I haz the power
4 years ago (2016-12-02 23:46:01 UTC) #55
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/8b5fc83dba9f525b0f707433a9fbb91465ca9bdd
Cr-Commit-Position: refs/heads/master@{#436079}

Powered by Google App Engine
This is Rietveld 408576698