components/search_engines/keyword_table.h - Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/keyword_table.h

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)

Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_engines/keyword_table.h

diff --git a/components/search_engines/keyword_table.h b/components/search_engines/keyword_table.h

index 2ac8695fca5750ea531e7f71224873defdad54f8..16a4474c6385a46770a3113f8cb5260731ea1f13 100644

--- a/components/search_engines/keyword_table.h

+++ b/components/search_engines/keyword_table.h

@@ -36,7 +36,6 @@ class Statement;

// keyword

// favicon_url

// url

-// show_in_default_list

// safe_for_autoreplace

// originating_url

// date_created This column was added after we allowed keywords.

@@ -131,6 +130,7 @@ class KeywordTable : public WebDatabaseTable {

// Table migration functions.

bool MigrateToVersion53AddNewTabURLColumn();

bool MigrateToVersion59RemoveExtensionKeywords();

+ bool MigrateToVersion68RemoveShowInDefaultListColumn();

private:

friend class KeywordTableTest;