chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc - Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)

Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/locale/special_locale_handler.cc ('k') | chrome/browser/importer/in_process_importer_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

diff --git a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

index 8ffa9275392a3d64c520fc9e2819eb4a48b9dfe8..7b8882b66c5128b0de506fbf8604476bb78bd76d 100644

--- a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

+++ b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

@@ -277,7 +277,6 @@ void SettingsOverridesAPI::RegisterSearchProvider(

std::string install_parameter = prefs->GetInstallParam(extension->id());

std::unique_ptr<TemplateURLData> data = ConvertSearchProvider(

profile_->GetPrefs(), *settings->search_engine, install_parameter);

- data->show_in_default_list = info->wants_to_be_default_engine;

auto turl = base::MakeUnique<TemplateURL>(

*data, TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION);

« no previous file with comments | « chrome/browser/android/locale/special_locale_handler.cc ('k') | chrome/browser/importer/in_process_importer_bridge.cc » ('j') | no next file with comments »