components/search_engines/template_url_prepopulate_data.cc - Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url_prepopulate_data.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)

Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_engines/template_url_prepopulate_data.cc

diff --git a/components/search_engines/template_url_prepopulate_data.cc b/components/search_engines/template_url_prepopulate_data.cc

index 72574064b75a2e62e25df051b83e4142941e8793..0eaa075f75ab7620fdd54c9e401934354058dcb9 100644

--- a/components/search_engines/template_url_prepopulate_data.cc

+++ b/components/search_engines/template_url_prepopulate_data.cc

@@ -1009,7 +1009,6 @@ std::unique_ptr<TemplateURLData> MakePrepopulatedTemplateURLData(

data->instant_url_post_params = instant_url_post_params.as_string();

data->image_url_post_params = image_url_post_params.as_string();

data->favicon_url = GURL(favicon_url);

- data->show_in_default_list = true;

data->safe_for_autoreplace = true;

data->input_encodings.push_back(encoding.as_string());

data->date_created = base::Time();