Change behaivor to decide whether a search engine should be shown in the default list

components/search_engines/template_url_service.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
 #define COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
 
 #include <stddef.h>
 
 #include <list>
@@ skipping 115 matching lines @@
   // keyword/url pair, or there is one but it can be replaced. If there is an
   // existing keyword that can be replaced and template_url_to_replace is
   // non-NULL, template_url_to_replace is set to the keyword to replace.
   //
   // |url| is the URL of the search query.  This is used to prevent auto-adding
   // a keyword for hosts already associated with a manually-edited keyword.
   bool CanAddAutogeneratedKeyword(const base::string16& keyword,
                                   const GURL& url,
                                   TemplateURL** template_url_to_replace);
 
+  // Returns whether the template_url should be shown in the list of engines

[Peter Kasting, 2016/11/14 19:59:16]

Nit: the template_url -> |template_url|

[ltian, 2016/11/15 19:43:41]

Done.

+  // most likely to be selected as a default engine. This is meant to highlight
+  // the current default, as well as the other most likely choices of default
+  // engine, separately from a full list of all TemplateURLs (which might be
+  // very long).
+  // An TemplateURL will be shown in this list if it is the default search

[Peter Kasting, 2016/11/14 19:59:16]

Nit: I would drop this paragraph, since it's simply describing the underlying
implementation details, which can be found by reading the code, and which risk
being out-of-sync if someone were to change that code without changing this.

[ltian, 2016/11/15 19:43:41]

Done.

+  // provider or its prepopulated id is greater than 0 or it is created by
+  // policy. And it should also support search term replacement.
+  bool ShowInDefaultList(const TemplateURL* template_url);
+
   // Adds to |matches| all TemplateURLs whose keywords begin with |prefix|,
   // sorted shortest-keyword-first. If |supports_replacement_only| is true, only
   // TemplateURLs that support replacement are returned.
   void AddMatchingKeywords(const base::string16& prefix,
                            bool supports_replacement_only,
                            TURLsAndMeaningfulLengths* matches);
 
   // Adds to |matches| all TemplateURLs for search engines with the domain
   // name part of the keyword starts with |prefix|, sorted
   // shortest-domain-name-first. If |supports_replacement_only| is true, only
@@ skipping 668 matching lines @@
   // Helper class to manage the default search engine.
   DefaultSearchManager default_search_manager_;
 
   std::unique_ptr<GoogleURLTracker::Subscription>
       google_url_updated_subscription_;
 
   DISALLOW_COPY_AND_ASSIGN(TemplateURLService);
 };
 
 #endif  // COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_