components/search_engines/default_search_pref_migration.cc - Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/default_search_pref_migration.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)

Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_engines/default_search_pref_migration.cc

diff --git a/components/search_engines/default_search_pref_migration.cc b/components/search_engines/default_search_pref_migration.cc

index 5912275f3b7707c3b5760f5134abdec6b3a8934d..cef04410a286776f60a25f3b2be3f755a89ef2fc 100644

--- a/components/search_engines/default_search_pref_migration.cc

+++ b/components/search_engines/default_search_pref_migration.cc

@@ -68,7 +68,6 @@ std::unique_ptr<TemplateURLData> LoadDefaultSearchProviderFromLegacyPrefs(

prefs->GetString(prefs::kDefaultSearchProviderImageURLPostParams);

default_provider_data->favicon_url =

GURL(prefs->GetString(prefs::kDefaultSearchProviderIconURL));

- default_provider_data->show_in_default_list = true;

default_provider_data->search_terms_replacement_key =

prefs->GetString(prefs::kDefaultSearchProviderSearchTermsReplacementKey);

default_provider_data->input_encodings = base::SplitString(