Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)

Created:
4 years, 2 months ago by sashab
Modified:
4 years, 2 months ago
CC:
aboxhall, aboxhall+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, krit, dtseng+watch_chromium.org, eae+blinkwatch, Eric Willigers, f(malita), fs, gavinp+loader_chromium.org, gyuyoung2, Nate Chapin, jchaffraix+rendering, je_julie, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, loading-reviews+fetch_chromium.org, nektar+watch_chromium.org, nektarios, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed EDisplay to an enum class and renamed its members to be keywords Changed EDisplay to an enum class and gave it an unsigned underlying type. Also renamed its members to match its keywords (e.g. inline, block, listItem) This is pre-work to move EDisplay to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/524f39aaebe8cae07b34925fca8a981e93432d92 Cr-Commit-Position: refs/heads/master@{#422023}

Patch Set 1 #

Patch Set 2 : Renamed members #

Total comments: 11

Patch Set 3 : Undid accidental renames #

Total comments: 2

Patch Set 4 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -208 lines) Patch
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 2 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 9 chunks +48 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PseudoElement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionElement.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLRTElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLRubyElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 1 chunk +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPagedFlowThread.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 8 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlMultiLine.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2365263002 Patch 1

Dependent Patchsets:

Issue 2366243002 Patch 40001
Issue 2366243002 Patch 60001

Messages

Total messages: 28 (13 generated)
sashab
Did them both in one CL this time :) https://codereview.chromium.org/2370673002/diff/20001/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (right): https://codereview.chromium.org/2370673002/diff/20001/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h#newcode1258 third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1258: ...
4 years, 2 months ago (2016-09-26 03:49:52 UTC) #3
sashab
Ignore that review comment. Be excited... :D
4 years, 2 months ago (2016-09-26 04:22:10 UTC) #4
alancutter (OOO until 2018)
https://codereview.chromium.org/2370673002/diff/20001/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (right): https://codereview.chromium.org/2370673002/diff/20001/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h#newcode1258 third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1258: // TODO(sashab): Check display is a valid EDisplay here. ...
4 years, 2 months ago (2016-09-26 04:23:47 UTC) #5
sashab
Psst... https://codereview.chromium.org/2366243002 ;) Woohoo!!
4 years, 2 months ago (2016-09-26 04:25:11 UTC) #6
sashab
Todo for next time: use regexes that take comments into account! :) https://codereview.chromium.org/2370673002/diff/20001/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp File third_party/WebKit/Source/core/layout/LayoutTableSection.cpp ...
4 years, 2 months ago (2016-09-26 04:48:39 UTC) #7
alancutter (OOO until 2018)
lgtm after comment is resolved. https://codereview.chromium.org/2370673002/diff/40001/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h File third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h (right): https://codereview.chromium.org/2370673002/diff/40001/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h#newcode5 third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h:5: /* ***** BEGIN LICENSE ...
4 years, 2 months ago (2016-09-27 05:27:32 UTC) #12
sashab
https://codereview.chromium.org/2370673002/diff/40001/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h File third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h (right): https://codereview.chromium.org/2370673002/diff/40001/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h#newcode5 third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h:5: /* ***** BEGIN LICENSE EDisplay::Block ***** On 2016/09/27 at ...
4 years, 2 months ago (2016-09-29 03:36:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370673002/60001
4 years, 2 months ago (2016-09-29 05:11:41 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/269329)
4 years, 2 months ago (2016-09-29 05:21:07 UTC) #18
sashab
Rune for owners -- thanks for looking at all these renames rune :)
4 years, 2 months ago (2016-09-30 03:00:55 UTC) #20
sashab
haraken@ RS please :)
4 years, 2 months ago (2016-09-30 03:18:09 UTC) #22
haraken
LGTM
4 years, 2 months ago (2016-09-30 03:56:59 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370673002/60001
4 years, 2 months ago (2016-09-30 04:03:42 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-30 04:09:51 UTC) #26
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 04:11:43 UTC) #28
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/524f39aaebe8cae07b34925fca8a981e93432d92
Cr-Commit-Position: refs/heads/master@{#422023}

Powered by Google App Engine
This is Rietveld 408576698