Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(298)

Issue 2365263002: Added isComputedStyle::isDisplayTableType() and made it static (Closed)

Created:
1 year, 9 months ago by sashab
Modified:
1 year, 8 months ago
Reviewers:
meade_UTC10, dstockwell
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added isComputedStyle::isDisplayTableType() and made it static Removed EDisplay FIRST_TABLE_DISPLAY and LAST_TABLE_DISPLAY from EDisplay, and moved them to a static function isDisplayTableType() on ComputedStyle. Also made the similar functions like this static functions, since they should have been static all along. BUG=628043 Committed: https://crrev.com/3c28edb5c5e9778fabb3642537b8138d5f5f1b83 Cr-Commit-Position: refs/heads/master@{#421749}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +12 lines, -4 lines 2 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
sashab
1 year, 9 months ago (2016-09-26 03:21:00 UTC) #2
meade_UTC10
lgtm https://codereview.chromium.org/2365263002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.h File third_party/WebKit/Source/core/style/ComputedStyle.h (right): https://codereview.chromium.org/2365263002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.h#newcode2496 third_party/WebKit/Source/core/style/ComputedStyle.h:2496: || display == TABLE_CAPTION; Nit: why not do ...
1 year, 9 months ago (2016-09-26 03:26:02 UTC) #5
sashab
dstockwell@ for OWNERS :) https://codereview.chromium.org/2365263002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.h File third_party/WebKit/Source/core/style/ComputedStyle.h (right): https://codereview.chromium.org/2365263002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.h#newcode2496 third_party/WebKit/Source/core/style/ComputedStyle.h:2496: || display == TABLE_CAPTION; On ...
1 year, 9 months ago (2016-09-26 03:28:32 UTC) #7
dstockwell
lgtm
1 year, 9 months ago (2016-09-26 04:22:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365263002/1
1 year, 8 months ago (2016-09-29 03:35:20 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
1 year, 8 months ago (2016-09-29 05:08:28 UTC) #13
commit-bot: I haz the power
1 year, 8 months ago (2016-09-29 05:10:49 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c28edb5c5e9778fabb3642537b8138d5f5f1b83
Cr-Commit-Position: refs/heads/master@{#421749}

Powered by Google App Engine
This is Rietveld 408576698