Added isComputedStyle::isDisplayTableType() and made it static

Added isComputedStyle::isDisplayTableType() and made it static

Removed EDisplay FIRST_TABLE_DISPLAY and LAST_TABLE_DISPLAY from
EDisplay, and moved them to a static function isDisplayTableType() on
ComputedStyle. Also made the similar functions like this static
functions, since they should have been static all along.

BUG=628043
Committed: https://crrev.com/3c28edb5c5e9778fabb3642537b8138d5f5f1b83
Cr-Commit-Position: refs/heads/master@{#421749}

[sashab, 2016-09-26 03:21:00]

sashab@chromium.org changed reviewers:
+ meade@chromium.org

[sashab, 2016-09-26 03:21:23]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 03:21:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2016-09-26 03:26:02]

lgtm

https://codereview.chromium.org/2365263002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2365263002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:2496: || display ==
TABLE_CAPTION;
Nit: why not do it the way it was before to save so many comparisons?
return display >= FIRST_TABLE_DISPLAY && display <= LAST_TABLE_DISPLAY
?

[sashab, 2016-09-26 03:28:31]

sashab@chromium.org changed reviewers:
+ dstockwell@chromium.org

[sashab, 2016-09-26 03:28:32]

dstockwell@ for OWNERS :)

https://codereview.chromium.org/2365263002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2365263002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:2496: || display ==
TABLE_CAPTION;
On 2016/09/26 at 03:26:02, Eddy wrote:
> Nit: why not do it the way it was before to save so many comparisons?
> return display >= FIRST_TABLE_DISPLAY && display <= LAST_TABLE_DISPLAY
> ?

Good point :) It's because A) Code like this causes so many problems when you
try to add a new one (see StyleRecalcChange) and B) EDisplay is about to become
an enum class, so numerical evaluators don't work (and for good reason!) :)

[dstockwell, 2016-09-26 04:22:57]

lgtm

[commit-bot: I haz the power, 2016-09-26 06:07:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 06:07:55]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sashab, 2016-09-29 03:35:10]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-09-29 03:35:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 05:08:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-29 05:10:49]

Description was changed from

==========
Added isComputedStyle::isDisplayTableType() and made it static

Removed EDisplay FIRST_TABLE_DISPLAY and LAST_TABLE_DISPLAY from
EDisplay, and moved them to a static function isDisplayTableType() on
ComputedStyle. Also made the similar functions like this static
functions, since they should have been static all along.

BUG=628043
==========

to

==========
Added isComputedStyle::isDisplayTableType() and made it static

Removed EDisplay FIRST_TABLE_DISPLAY and LAST_TABLE_DISPLAY from
EDisplay, and moved them to a static function isDisplayTableType() on
ComputedStyle. Also made the similar functions like this static
functions, since they should have been static all along.

BUG=628043

Committed: https://crrev.com/3c28edb5c5e9778fabb3642537b8138d5f5f1b83
Cr-Commit-Position: refs/heads/master@{#421749}
==========

[commit-bot: I haz the power, 2016-09-29 05:10:49]

Patchset 1 (id:??) landed as
https://crrev.com/3c28edb5c5e9778fabb3642537b8138d5f5f1b83
Cr-Commit-Position: refs/heads/master@{#421749}