third_party/WebKit/Source/core/layout/LayoutTableSection.cpp - Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)

Patch Set: Comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableRow.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTextControlMultiLine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

index 2edd3bc3d5ce3847941bc9e303c3a86110b3a4ca..9d5b1422ba4fb65d550a7155df92d82e78d83328 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

@@ -119,7 +119,7 @@ LayoutTableSection::~LayoutTableSection()

void LayoutTableSection::styleDidChange(StyleDifference diff, const ComputedStyle* oldStyle)

{

- DCHECK(style()->display() == TABLE_FOOTER_GROUP || style()->display() == TABLE_ROW_GROUP || style()->display() == TABLE_HEADER_GROUP);

+ DCHECK(style()->display() == EDisplay::TableFooterGroup || style()->display() == EDisplay::TableRowGroup || style()->display() == EDisplay::TableHeaderGroup);

LayoutTableBoxComponent::styleDidChange(diff, oldStyle);

propagateStyleToAnonymousChildren();

@@ -1696,7 +1696,7 @@ bool LayoutTableSection::nodeAtPoint(HitTestResult& result, const HitTestLocatio

LayoutTableSection* LayoutTableSection::createAnonymousWithParent(const LayoutObject* parent)

{

- RefPtr<ComputedStyle> newStyle = ComputedStyle::createAnonymousStyleWithDisplay(parent->styleRef(), TABLE_ROW_GROUP);

+ RefPtr<ComputedStyle> newStyle = ComputedStyle::createAnonymousStyleWithDisplay(parent->styleRef(), EDisplay::TableRowGroup);

LayoutTableSection* newSection = new LayoutTableSection(nullptr);

newSection->setDocumentForAnonymous(&parent->document());

newSection->setStyle(newStyle.release());