Remove all ordering requirements in CSSValueKeywords.in (WIP)

Remove all ordering requirements in CSSValueKeywords.in

Remove ordering requirement dependencies for all enums in
CSSValueKeywords.in by removing the 'minus' operations that
converted them and using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Conversion operations were found using these search queries:
https://cs.chromium.org/search/?q=(%5B%5C%2B%5C-%5D%5Cs%2BCSSValue%5BA-Za-z0-9%5D%2B)%7C(CSSValue%5BA-Za-z0-9%5D%2B%5Cs%2B%5B%5C%2B%5C-%5D)&sq=package:chromium&type=cs
https://cs.chromium.org/search/?q=(((%3C%3D?)%7C(%3E%3D?))%5Cs%2BCSSValue%5BA-Za-z0-9%5D%2B)%7C(CSSValue%5BA-Za-z0-9%5D%2B%5Cs%2B((%3C%3D?)%7C(%3E%3D?)))&sq=package:chromium&type=cs

Also added some conversion functions independent of CSSPrimitiveValue,
which is part of a longer-term goal to generate them and remove
CSSPrimitiveValue from the equation.

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)

BUG=665272

[sashab, 2016-09-26 04:25:21]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 04:25:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-09-26 04:26:20]

sashab@chromium.org changed reviewers:
+ esprehn@chromium.org

[sashab, 2016-09-26 04:26:20]

:D

[sashab, 2016-09-26 04:30:07]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org

[sashab, 2016-09-26 04:30:08]

alancutter@ for initial review, esprehn@ for OWNERs.

[commit-bot: I haz the power, 2016-09-26 05:14:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 05:14:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[esprehn, 2016-09-28 03:54:44]

lgtm

[alancutter (OOO until 2018), 2016-09-28 04:03:50]

I'm in favour for this change (as it's on the path to generating
ComputedStyleConstants) but I don't think it removes all ordering requirements
everywhere in the code as the description claims.
CSSPropertyParser.cpp:consumeFontWeight() and
ComputedStyleCSSValueMapping.cpp:valueForContentData() for example.

[sashab, 2016-09-28 23:58:20]

Description was changed from

==========
Remove all ordering requirements in CSSValueKeywords.in

Remove all ordering requirement dependencies between CSSValueKeywords.in
and ComputedStyleConstants.h by removing the 'minus' operations that
converted the two, using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)
==========

to

==========
Remove all ordering requirements in CSSValueKeywords.in

Remove all ordering requirement dependencies between CSSValueKeywords.in
and ComputedStyleConstants.h by removing the 'minus' operations that
converted the two, using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Conversion operations were found using this search query:
https://cs.chromium.org/search/?q=(%5B%5C%2B%5C-%5D%5Cs%2BCSSValue%5BA-Za-z%5...

Also added some conversion functions independent of CSSPrimitiveValue,
which is part of a longer-term goal to generate them and remove
CSSPrimitiveValue from the equation.

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)
==========

[sashab, 2016-09-29 00:02:39]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 00:03:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-09-29 00:06:58]

Hey alan -- see new CL description and patch. Since elliott's already lgtmd the
overall look of this patch, if you LGTM this I'll land it.

[commit-bot: I haz the power, 2016-09-29 00:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 00:14:00]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alancutter (OOO until 2018), 2016-09-29 03:02:17]

lgtm with "all" removed from the title since it doesn't mention
ComputedStyleConstants.h.

[sashab, 2016-09-29 03:34:55]

Description was changed from

==========
Remove all ordering requirements in CSSValueKeywords.in

Remove all ordering requirement dependencies between CSSValueKeywords.in
and ComputedStyleConstants.h by removing the 'minus' operations that
converted the two, using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Conversion operations were found using this search query:
https://cs.chromium.org/search/?q=(%5B%5C%2B%5C-%5D%5Cs%2BCSSValue%5BA-Za-z%5...

Also added some conversion functions independent of CSSPrimitiveValue,
which is part of a longer-term goal to generate them and remove
CSSPrimitiveValue from the equation.

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)
==========

to

==========
Remove ordering requirements in CSSValueKeywords.in

Remove ordering requirement dependencies between CSSValueKeywords.in
and ComputedStyleConstants.h by removing the 'minus' operations that
converted the two, using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Conversion operations were found using this search query:
https://cs.chromium.org/search/?q=(%5B%5C%2B%5C-%5D%5Cs%2BCSSValue%5BA-Za-z%5...

Also added some conversion functions independent of CSSPrimitiveValue,
which is part of a longer-term goal to generate them and remove
CSSPrimitiveValue from the equation.

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)
==========

[sashab, 2016-09-29 04:14:43]

Description was changed from

==========
Remove ordering requirements in CSSValueKeywords.in

Remove ordering requirement dependencies between CSSValueKeywords.in
and ComputedStyleConstants.h by removing the 'minus' operations that
converted the two, using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Conversion operations were found using this search query:
https://cs.chromium.org/search/?q=(%5B%5C%2B%5C-%5D%5Cs%2BCSSValue%5BA-Za-z%5...

Also added some conversion functions independent of CSSPrimitiveValue,
which is part of a longer-term goal to generate them and remove
CSSPrimitiveValue from the equation.

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)
==========

to

==========
Remove all ordering requirements in CSSValueKeywords.in

Remove ordering requirement dependencies for all enums in
CSSValueKeywords.in by removing the 'minus' operations that
converted them and using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Conversion operations were found using this search query:
https://cs.chromium.org/search/?q=(%5B%5C%2B%5C-%5D%5Cs%2BCSSValue%5BA-Za-z0-...

Also added some conversion functions independent of CSSPrimitiveValue,
which is part of a longer-term goal to generate them and remove
CSSPrimitiveValue from the equation.

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)
==========

[alancutter (OOO until 2018), 2016-09-29 05:40:53]

On 2016/09/29 at 03:02:17, alancutter wrote:
> lgtm with "all" removed from the title since it doesn't mention
ComputedStyleConstants.h.

As discussed in person I take back the "remove \"all\"" requirement, I'm
satisfied that the query should remove all ordering dependencies in the code
base.

Please also remove the instances in CSSPropertyParser.cpp:consumeFontWeight()
and StyleBuilderCustom.cpp:applyValueCSSPropertyContent() that appear in the
search results before landing.

[Timothy Loh, 2016-09-29 05:49:25]

On 2016/09/29 05:40:53, alancutter wrote:
> On 2016/09/29 at 03:02:17, alancutter wrote:
> > lgtm with "all" removed from the title since it doesn't mention
> ComputedStyleConstants.h.
> 
> As discussed in person I take back the "remove \"all\"" requirement, I'm
> satisfied that the query should remove all ordering dependencies in the code
> base.

This is easy to test, just randomly reorder the .in file and see if the tests
still pass.

[sashab, 2016-09-30 03:13:13]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 03:13:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 04:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 04:02:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2016-09-30 04:19:49]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 04:20:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 04:59:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 04:59:45]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sashab, 2016-10-05 00:31:17]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-10-05 00:31:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2366243002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-05 00:31:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 00:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 00:45:51]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2016-10-10 00:51:20]

Looks like we still need to deal with inequality checks on CSSValueIDs.
https://cs.chromium.org/search/?q=(((%3C%3D?)%7C(%3E%3D?))%5Cs%2BCSSValue%5BA...

timloh's suggestion of randomising the .in file and running all layout tests is
probably a good sanity check. Maybe add a seeded randomise to
make_css_value_keywords.py?

[sashab, 2016-11-15 00:26:37]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 00:27:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-11-15 01:52:17]

Description was changed from

==========
Remove all ordering requirements in CSSValueKeywords.in

Remove ordering requirement dependencies for all enums in
CSSValueKeywords.in by removing the 'minus' operations that
converted them and using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Conversion operations were found using this search query:
https://cs.chromium.org/search/?q=(%5B%5C%2B%5C-%5D%5Cs%2BCSSValue%5BA-Za-z0-...

Also added some conversion functions independent of CSSPrimitiveValue,
which is part of a longer-term goal to generate them and remove
CSSPrimitiveValue from the equation.

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)
==========

to

==========
Remove all ordering requirements in CSSValueKeywords.in

Remove ordering requirement dependencies for all enums in
CSSValueKeywords.in by removing the 'minus' operations that
converted them and using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Conversion operations were found using these search queries:
https://cs.chromium.org/search/?q=(%5B%5C%2B%5C-%5D%5Cs%2BCSSValue%5BA-Za-z0-...
https://cs.chromium.org/search/?q=(((%3C%3D?)%7C(%3E%3D?))%5Cs%2BCSSValue%5BA...

Also added some conversion functions independent of CSSPrimitiveValue,
which is part of a longer-term goal to generate them and remove
CSSPrimitiveValue from the equation.

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)
==========

[sashab, 2016-11-15 02:38:49]

I did reorder the file randomly, and it caused more errors. I think I'm going to
break this patch up and land it in stages, this will also help make it clearer
where this error is occurring.

[sashab, 2016-11-17 03:41:40]

Description was changed from

==========
Remove all ordering requirements in CSSValueKeywords.in

Remove ordering requirement dependencies for all enums in
CSSValueKeywords.in by removing the 'minus' operations that
converted them and using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Conversion operations were found using these search queries:
https://cs.chromium.org/search/?q=(%5B%5C%2B%5C-%5D%5Cs%2BCSSValue%5BA-Za-z0-...
https://cs.chromium.org/search/?q=(((%3C%3D?)%7C(%3E%3D?))%5Cs%2BCSSValue%5BA...

Also added some conversion functions independent of CSSPrimitiveValue,
which is part of a longer-term goal to generate them and remove
CSSPrimitiveValue from the equation.

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)
==========

to

==========
Remove all ordering requirements in CSSValueKeywords.in

Remove ordering requirement dependencies for all enums in
CSSValueKeywords.in by removing the 'minus' operations that
converted them and using explicit switch statements instead. This not
only makes the code much clearer and easier to understand, but is
future-proof and compatible with the upcoming change that makes all
ComputedStyleConstants enums enum classes (and hence no numerical
operations are possible).

Conversion operations were found using these search queries:
https://cs.chromium.org/search/?q=(%5B%5C%2B%5C-%5D%5Cs%2BCSSValue%5BA-Za-z0-...
https://cs.chromium.org/search/?q=(((%3C%3D?)%7C(%3E%3D?))%5Cs%2BCSSValue%5BA...

Also added some conversion functions independent of CSSPrimitiveValue,
which is part of a longer-term goal to generate them and remove
CSSPrimitiveValue from the equation.

Also, since ComputedStyleConstants will eventually be generated, the
verbosity of this patch is not a problem. :)

BUG=665272
==========