third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp - Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)

Patch Set: Comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp b/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

index 843cb9259d99dcb96640295a0f6bea9729b5efb6..e9b35880e778a01f72b23994d763b783f161f7dc 100644

--- a/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

@@ -99,7 +99,7 @@ PassRefPtr<ComputedStyle> HTMLImageFallbackHelper::customStyleForAltText(Element

// This is an <img> with no attributes, so don't display anything.

if (noImageSourceSpecified(element) && !newStyle->width().isSpecifiedOrIntrinsic() && !newStyle->height().isSpecifiedOrIntrinsic() && toHTMLElement(element).altText().isEmpty())

- newStyle->setDisplay(NONE);

+ newStyle->setDisplay(EDisplay::None);

// This preserves legacy behaviour originally defined when alt-text was managed by LayoutImage.

if (noImageSourceSpecified(element))