third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)

Patch Set: Comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 41cce8b39562275ee51fa60ed2735da35cb0a21a..9b83099139f12bdb4b445249c5b6a0f6cb08abf8 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -734,7 +734,7 @@ bool ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation(const ComputedStyle&

|| (borderRightStyle() == BorderStyleHidden && other.borderRightStyle() == BorderStyleNone)

|| (borderRightStyle() == BorderStyleNone && other.borderRightStyle() == BorderStyleHidden)))

return true;

- } else if (m_nonInheritedData.m_effectiveDisplay == LIST_ITEM) {

+ } else if (display() == EDisplay::ListItem) {

if (m_inheritedData.m_listStyleType != other.m_inheritedData.m_listStyleType

|| m_inheritedData.m_listStylePosition != other.m_inheritedData.m_listStylePosition)

return true;