Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)
Patch Set: Comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 { 96 {
97 RefPtr<ComputedStyle> fullscreenStyle = ComputedStyle::create(); 97 RefPtr<ComputedStyle> fullscreenStyle = ComputedStyle::create();
98 98
99 // Create a stacking context: 99 // Create a stacking context:
100 fullscreenStyle->setZIndex(INT_MAX); 100 fullscreenStyle->setZIndex(INT_MAX);
101 fullscreenStyle->setIsStackingContext(true); 101 fullscreenStyle->setIsStackingContext(true);
102 102
103 fullscreenStyle->setFontDescription(FontDescription()); 103 fullscreenStyle->setFontDescription(FontDescription());
104 fullscreenStyle->font().update(nullptr); 104 fullscreenStyle->font().update(nullptr);
105 105
106 fullscreenStyle->setDisplay(FLEX); 106 fullscreenStyle->setDisplay(EDisplay::Flex);
107 fullscreenStyle->setJustifyContentPosition(ContentPositionCenter); 107 fullscreenStyle->setJustifyContentPosition(ContentPositionCenter);
108 // TODO (lajava): Since the FullScrenn layout object is anonymous, its Defau lt Alignment (align-items) value can't be used to resolve its children Self Alig nment 'auto' values. 108 // TODO (lajava): Since the FullScrenn layout object is anonymous, its Defau lt Alignment (align-items) value can't be used to resolve its children Self Alig nment 'auto' values.
109 fullscreenStyle->setAlignItemsPosition(ItemPositionCenter); 109 fullscreenStyle->setAlignItemsPosition(ItemPositionCenter);
110 fullscreenStyle->setFlexDirection(FlowColumn); 110 fullscreenStyle->setFlexDirection(FlowColumn);
111 111
112 fullscreenStyle->setPosition(FixedPosition); 112 fullscreenStyle->setPosition(FixedPosition);
113 fullscreenStyle->setLeft(Length(0, blink::Fixed)); 113 fullscreenStyle->setLeft(Length(0, blink::Fixed));
114 fullscreenStyle->setTop(Length(0, blink::Fixed)); 114 fullscreenStyle->setTop(Length(0, blink::Fixed));
115 IntSize viewportSize = document().page()->frameHost().visualViewport().size( ); 115 IntSize viewportSize = document().page()->frameHost().visualViewport().size( );
116 fullscreenStyle->setWidth(Length(viewportSize.width(), blink::Fixed)); 116 fullscreenStyle->setWidth(Length(viewportSize.width(), blink::Fixed));
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 m_placeholder->setStyleWithWritingModeOfParent(std::move(style)); 203 m_placeholder->setStyleWithWritingModeOfParent(std::move(style));
204 if (parent()) { 204 if (parent()) {
205 parent()->addChildWithWritingModeOfParent(m_placeholder, this); 205 parent()->addChildWithWritingModeOfParent(m_placeholder, this);
206 parent()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation( LayoutInvalidationReason::Fullscreen); 206 parent()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation( LayoutInvalidationReason::Fullscreen);
207 } 207 }
208 } else { 208 } else {
209 m_placeholder->setStyle(std::move(style)); 209 m_placeholder->setStyle(std::move(style));
210 m_placeholder->setStyleWithWritingModeOfParent(std::move(style)); 210 m_placeholder->setStyleWithWritingModeOfParent(std::move(style));
211 } 211 }
212 } 212 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698