Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)
Patch Set: Comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 , m_isFirstAfterPageBreak(false) 60 , m_isFirstAfterPageBreak(false)
61 #if ENABLE(ASSERT) 61 #if ENABLE(ASSERT)
62 , m_hasBadChildList(false) 62 , m_hasBadChildList(false)
63 #endif 63 #endif
64 { 64 {
65 // Internet Explorer and Firefox always create a marker for list items, even when the list-style-type is none. We do not make a marker 65 // Internet Explorer and Firefox always create a marker for list items, even when the list-style-type is none. We do not make a marker
66 // in the list-style-type: none case, since it is wasteful to do so. Ho wever, in order to match other browsers we have to pretend like 66 // in the list-style-type: none case, since it is wasteful to do so. Ho wever, in order to match other browsers we have to pretend like
67 // an invisible marker exists. The side effect of having an invisible m arker is that the quirks mode behavior of shrinking lines with no 67 // an invisible marker exists. The side effect of having an invisible m arker is that the quirks mode behavior of shrinking lines with no
68 // text children must not apply. This change also means that gaps will exist between image bullet list items. Even when the list bullet 68 // text children must not apply. This change also means that gaps will exist between image bullet list items. Even when the list bullet
69 // is an image, the line is still considered to be immune from the quirk . 69 // is an image, the line is still considered to be immune from the quirk .
70 m_hasTextChildren = lineLayoutItem.style()->display() == LIST_ITEM; 70 m_hasTextChildren = lineLayoutItem.style()->display() == EDisplay::ListI tem;
71 m_hasTextDescendants = m_hasTextChildren; 71 m_hasTextDescendants = m_hasTextChildren;
72 } 72 }
73 73
74 #if ENABLE(ASSERT) 74 #if ENABLE(ASSERT)
75 ~InlineFlowBox() override; 75 ~InlineFlowBox() override;
76 #endif 76 #endif
77 77
78 #ifndef NDEBUG 78 #ifndef NDEBUG
79 void showLineTreeAndMark(const InlineBox* = nullptr, const char* = nullptr, const InlineBox* = nullptr, const char* = nullptr, const LayoutObject* = nullptr , int = 0) const override; 79 void showLineTreeAndMark(const InlineBox* = nullptr, const char* = nullptr, const InlineBox* = nullptr, const char* = nullptr, const LayoutObject* = nullptr , int = 0) const override;
80 #endif 80 #endif
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 inline void InlineFlowBox::setHasBadChildList() 368 inline void InlineFlowBox::setHasBadChildList()
369 { 369 {
370 #if ENABLE(ASSERT) 370 #if ENABLE(ASSERT)
371 m_hasBadChildList = true; 371 m_hasBadChildList = true;
372 #endif 372 #endif
373 } 373 }
374 374
375 } // namespace blink 375 } // namespace blink
376 376
377 #endif // InlineFlowBox_h 377 #endif // InlineFlowBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698