third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)

Patch Set: Comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index 56b3a1226d88432625331e2f5579a27ba28d1d32..9b8c09b914beca2c3f26e1cb1bcc8a79fe48cc96 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -266,8 +266,8 @@ void LayoutBoxModelObject::styleDidChange(StyleDifference diff, const ComputedSt

if (oldStyle && isOutOfFlowPositioned() && parent() && (parent() != containingBlock())

&& (styleRef().position() == oldStyle->position())

&& (styleRef().originalDisplay() != oldStyle->originalDisplay())

- && ((styleRef().originalDisplay() == BLOCK) || (styleRef().originalDisplay() == INLINE_BLOCK))

- && ((oldStyle->originalDisplay() == BLOCK) || (oldStyle->originalDisplay() == INLINE_BLOCK)))

+ && ((styleRef().originalDisplay() == EDisplay::Block) || (styleRef().originalDisplay() == EDisplay::InlineBlock))

+ && ((oldStyle->originalDisplay() == EDisplay::Block) || (oldStyle->originalDisplay() == EDisplay::InlineBlock)))

parent()->setNeedsLayout(LayoutInvalidationReason::ChildChanged, MarkContainerChain);

PaintLayerType type = layerTypeRequired();