third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)

Patch Set: Comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index d2285ac8f6bc584732cbabbeb72f05fdce6c60d1..871d49e2d85cb1a62cf66d366e87e7ff245561cc 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2822,7 +2822,7 @@ bool LayoutBox::skipContainingBlockForPercentHeightCalculation(const LayoutBox*

// objects, such as table-cells, will be treated just as if they were non-anonymous.

if (containingBlock->isAnonymous()) {

EDisplay display = containingBlock->styleRef().display();

- return display == BLOCK || display == INLINE_BLOCK;

+ return display == EDisplay::Block || display == EDisplay::InlineBlock;

}

// For quirks mode, we skip most auto-height containing blocks when computing percentages.