Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGGElement.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)
Patch Set: Comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 21 matching lines...) Expand all
32 } 32 }
33 33
34 DEFINE_NODE_FACTORY(SVGGElement) 34 DEFINE_NODE_FACTORY(SVGGElement)
35 35
36 LayoutObject* SVGGElement::createLayoutObject(const ComputedStyle& style) 36 LayoutObject* SVGGElement::createLayoutObject(const ComputedStyle& style)
37 { 37 {
38 // SVG 1.1 testsuite explicitely uses constructs like <g display="none"><lin earGradient> 38 // SVG 1.1 testsuite explicitely uses constructs like <g display="none"><lin earGradient>
39 // We still have to create layoutObjects for the <g> & <linearGradient> elem ent, though the 39 // We still have to create layoutObjects for the <g> & <linearGradient> elem ent, though the
40 // subtree may be hidden - we only want the resource layoutObjects to exist so they can be 40 // subtree may be hidden - we only want the resource layoutObjects to exist so they can be
41 // referenced from somewhere else. 41 // referenced from somewhere else.
42 if (style.display() == NONE) 42 if (style.display() == EDisplay::None)
43 return new LayoutSVGHiddenContainer(this); 43 return new LayoutSVGHiddenContainer(this);
44 44
45 return new LayoutSVGTransformableContainer(this); 45 return new LayoutSVGTransformableContainer(this);
46 } 46 }
47 47
48 bool SVGGElement::layoutObjectIsNeeded(const ComputedStyle&) 48 bool SVGGElement::layoutObjectIsNeeded(const ComputedStyle&)
49 { 49 {
50 // Unlike SVGElement::layoutObjectIsNeeded(), we still create layoutObjects, even if 50 // Unlike SVGElement::layoutObjectIsNeeded(), we still create layoutObjects, even if
51 // display is set to 'none' - which is special to SVG <g> container elements . 51 // display is set to 'none' - which is special to SVG <g> container elements .
52 return parentOrShadowHostElement() && parentOrShadowHostElement()->isSVGElem ent(); 52 return parentOrShadowHostElement() && parentOrShadowHostElement()->isSVGElem ent();
53 } 53 }
54 54
55 } // namespace blink 55 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698