Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)
Patch Set: Comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
index 9f6179739a6c1e7b78ccc6e93e37737c2f646e6a..4343154c6200d30b426b55e10105bd0e9beed105 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
@@ -1757,15 +1757,15 @@ LayoutBlock* LayoutBlock::createAnonymousWithParentAndDisplay(const LayoutObject
// FIXME: Do we need to convert all our inline displays to block-type in the anonymous logic ?
EDisplay newDisplay;
LayoutBlock* newBox = nullptr;
- if (display == FLEX || display == INLINE_FLEX) {
+ if (display == EDisplay::Flex || display == EDisplay::InlineFlex) {
newBox = LayoutFlexibleBox::createAnonymous(&parent->document());
- newDisplay = FLEX;
- } else if (display == GRID || display == INLINE_GRID) {
+ newDisplay = EDisplay::Flex;
+ } else if (display == EDisplay::Grid || display == EDisplay::InlineGrid) {
newBox = LayoutGrid::createAnonymous(&parent->document());
- newDisplay = GRID;
+ newDisplay = EDisplay::Grid;
} else {
newBox = LayoutBlockFlow::createAnonymous(&parent->document());
- newDisplay = BLOCK;
+ newDisplay = EDisplay::Block;
}
RefPtr<ComputedStyle> newStyle = ComputedStyle::createAnonymousStyleWithDisplay(parent->styleRef(), newDisplay);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.h ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698