Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)
Patch Set: Comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 1796 matching lines...) Expand 10 before | Expand all | Expand 10 after
1807 if (layoutObject()) 1807 if (layoutObject())
1808 applyTextTransform(layoutObject()->style(), itemString, ' '); 1808 applyTextTransform(layoutObject()->style(), itemString, ' ');
1809 return itemString; 1809 return itemString;
1810 } 1810 }
1811 1811
1812 bool HTMLSelectElement::itemIsDisplayNone(Element& element) const 1812 bool HTMLSelectElement::itemIsDisplayNone(Element& element) const
1813 { 1813 {
1814 if (isHTMLOptionElement(element)) 1814 if (isHTMLOptionElement(element))
1815 return toHTMLOptionElement(element).isDisplayNone(); 1815 return toHTMLOptionElement(element).isDisplayNone();
1816 if (const ComputedStyle* style = itemComputedStyle(element)) 1816 if (const ComputedStyle* style = itemComputedStyle(element))
1817 return style->display() == NONE; 1817 return style->display() == EDisplay::None;
1818 return false; 1818 return false;
1819 } 1819 }
1820 1820
1821 const ComputedStyle* HTMLSelectElement::itemComputedStyle(Element& element) cons t 1821 const ComputedStyle* HTMLSelectElement::itemComputedStyle(Element& element) cons t
1822 { 1822 {
1823 return element.computedStyle() ? element.computedStyle() : element.ensureCom putedStyle(); 1823 return element.computedStyle() ? element.computedStyle() : element.ensureCom putedStyle();
1824 } 1824 }
1825 1825
1826 LayoutUnit HTMLSelectElement::clientPaddingLeft() const 1826 LayoutUnit HTMLSelectElement::clientPaddingLeft() const
1827 { 1827 {
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
2024 } 2024 }
2025 2025
2026 void HTMLSelectElement::didMutateSubtree() 2026 void HTMLSelectElement::didMutateSubtree()
2027 { 2027 {
2028 DCHECK(popupIsVisible()); 2028 DCHECK(popupIsVisible());
2029 DCHECK(m_popup); 2029 DCHECK(m_popup);
2030 m_popup->updateFromElement(PopupMenu::ByDOMChange); 2030 m_popup->updateFromElement(PopupMenu::ByDOMChange);
2031 } 2031 }
2032 2032
2033 } // namespace blink 2033 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698