Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23498059: Remove last dependencies on ui/base from ui/gfx (Closed)

Created:
7 years, 3 months ago by Ben Goodger (Google)
Modified:
7 years, 2 months ago
Reviewers:
tfarina, sky
CC:
chromium-reviews, rsesek+watch_chromium.org, cc-bugs_chromium.org, derat+watch_chromium.org
Visibility:
Public.

Description

Remove last dependencies on ui/base from ui/gfx BUG=103304 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225722

Patch Set 1 #

Patch Set 2 : Fix DEPS file #

Total comments: 17

Patch Set 3 : Fix indent #

Patch Set 4 : Rebase #

Patch Set 5 : Fix build #

Patch Set 6 : rebase #

Total comments: 5

Patch Set 7 : Require explicit initialization #

Patch Set 8 : . #

Patch Set 9 : rebase #

Patch Set 10 : fix checkdeps #

Patch Set 11 : last rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -383 lines) Patch
M ui/aura/test/test_aura_initializer.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
A ui/base/win/dpi_setup.h View 1 2 3 4 5 6 1 chunk +22 lines, -0 lines 0 comments Download
A ui/base/win/dpi_setup.cc View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
M ui/base/win/foreground_helper.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/test_suite.cc View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M ui/gfx/DEPS View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/android/device_display_info.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/android/java_bitmap.h View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/gfx/blit.h View 1 2 1 chunk +17 lines, -17 lines 0 comments Download
M ui/gfx/box_f.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas_paint.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas_paint_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas_paint_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas_paint_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/codec/jpeg_codec.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/codec/png_codec.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/color_analysis.h View 1 2 7 chunks +9 lines, -9 lines 0 comments Download
M ui/gfx/color_profile.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/color_utils.h View 1 2 4 chunks +12 lines, -12 lines 0 comments Download
M ui/gfx/display.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/display_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/favicon_size.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/font.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_fallback_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/font_list.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_render_params_linux.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/gdi_util.h View 1 2 2 chunks +12 lines, -10 lines 0 comments Download
M ui/gfx/gfx_export.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gfx/gfx_paths.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gtk_native_view_id_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gtk_preserve_window.h View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M ui/gfx/gtk_util.h View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M ui/gfx/icon_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/cairo_cached_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/canvas_image_source.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_family.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/image/image_ios.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/image/image_png_rep.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_operations.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_rep.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_source.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_util_ios.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/image/image_skia_util_mac.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M ui/gfx/image/image_util.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/insets.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/insets_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/insets_f.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/interpolated_transform.h View 8 chunks +9 lines, -8 lines 0 comments Download
M ui/gfx/matrix3_f.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/pango_util.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M ui/gfx/path.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/path_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/path_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_pango.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/point.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/point3_f.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/point_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/point_conversions.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/point_f.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/quad_f.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/range/range.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/rect.h View 3 chunks +7 lines, -7 lines 0 comments Download
M ui/gfx/rect_base.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/rect_conversions.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/gfx/rect_f.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/render_text.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen_type_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/screen_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/scrollbar_size.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/selection_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/sequential_id_generator.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/shadow_value.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/size.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/size_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/size_conversions.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/size_f.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/skbitmap_operations.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/skia_util.h View 1 2 2 chunks +18 lines, -18 lines 0 comments Download
M ui/gfx/skia_utils_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/switches.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/sys_color_change_listener.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/text_elider.h View 1 2 8 chunks +49 lines, -49 lines 0 comments Download
M ui/gfx/text_utils.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M ui/gfx/transform.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/transform_util.h View 1 2 3 4 5 2 chunks +9 lines, -9 lines 0 comments Download
M ui/gfx/utf16_indexing.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M ui/gfx/vector2d.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/vector2d_conversions.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/vector2d_f.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/vector3d_f.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/win/dpi.h View 1 2 3 4 5 6 7 8 2 chunks +24 lines, -14 lines 0 comments Download
M ui/gfx/win/dpi.cc View 1 2 3 4 5 6 7 8 5 chunks +19 lines, -28 lines 0 comments Download
M ui/gfx/win/hwnd_util.h View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M ui/gfx/win/window_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Ben Goodger (Google)
7 years, 3 months ago (2013-09-24 18:29:26 UTC) #1
tfarina
Ben, I have updated the CL description to reference crbug.com/103304
7 years, 3 months ago (2013-09-24 19:00:48 UTC) #2
sky
LGTM https://codereview.chromium.org/23498059/diff/4001/ui/gfx/blit.h File ui/gfx/blit.h (right): https://codereview.chromium.org/23498059/diff/4001/ui/gfx/blit.h#newcode21 ui/gfx/blit.h:21: const Rect& dst_rect, nit: indent one more here ...
7 years, 3 months ago (2013-09-24 19:11:39 UTC) #3
Ben Goodger (Google)
sky, please take another look: chrome_browser_main_parts_win dpi_setup* gfx/win/dpi*
7 years, 2 months ago (2013-09-25 19:17:44 UTC) #4
sky
https://codereview.chromium.org/23498059/diff/31001/chrome/browser/chrome_browser_main_win.cc File chrome/browser/chrome_browser_main_win.cc (right): https://codereview.chromium.org/23498059/diff/31001/chrome/browser/chrome_browser_main_win.cc#newcode206 chrome/browser/chrome_browser_main_win.cc:206: ui::win::InitDeviceScaleFactor(); Should this be earlier on? Maybe before toolkit ...
7 years, 2 months ago (2013-09-25 19:28:14 UTC) #5
sky
https://codereview.chromium.org/23498059/diff/31001/ui/gfx/win/dpi.cc File ui/gfx/win/dpi.cc (right): https://codereview.chromium.org/23498059/diff/31001/ui/gfx/win/dpi.cc#newcode98 ui/gfx/win/dpi.cc:98: return g_device_scale_factor; I think we should DCHECK if not ...
7 years, 2 months ago (2013-09-25 19:30:53 UTC) #6
Ben Goodger (Google)
ok updated, check out dpi_setup, dpi.cc, and resource_bundle as an example
7 years, 2 months ago (2013-09-25 21:38:36 UTC) #7
sky
LGTM
7 years, 2 months ago (2013-09-25 22:32:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/23498059/81001
7 years, 2 months ago (2013-09-26 22:00:03 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=82009
7 years, 2 months ago (2013-09-27 02:54:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/23498059/81001
7 years, 2 months ago (2013-09-27 04:53:02 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=82190
7 years, 2 months ago (2013-09-27 09:25:58 UTC) #12
Ben Goodger (Google)
7 years, 2 months ago (2013-09-27 16:56:39 UTC) #13
Message was sent while issue was closed. 
Committed patchset #11 manually as r225722 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698