Make PasswordFormManager::best_matches_ const

Make PasswordFormManager::best_matches_ const

...and also the related lists of passwords from PasswordStore.
PasswordFormManager should not really modify them, and will not be able to do
so once their ownership will transfer to the coming FormFetcher, shared among
multiple PasswordFormManagers.

As a side-effect, this CL also gets rid of two aliases for maps involving
PasswordForm. While the map's signature is long, it is more helpful to spell it
out than to hide it behind a cryptic PasswordFormMap, or similar, which does
not hint on ownership involved in the map.

BUG=621355
Committed: https://crrev.com/a5406f79261a94c55b0826fac05f73375ded7d15
Cr-Commit-Position: refs/heads/master@{#414016}

[vabr (Chromium), 2016-08-19 21:17:00]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 21:17:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:16:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 23:16:41]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-08-20 11:11:46]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 11:11:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-20 11:23:45]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 11:23:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 12:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 12:12:42]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-08-20 12:18:39]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 12:18:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 12:55:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 12:55:26]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[vabr (Chromium), 2016-08-22 12:35:25]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 12:35:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 12:38:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 12:38:10]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vabr (Chromium), 2016-08-22 12:41:14]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 12:41:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 12:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 12:44:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vabr (Chromium), 2016-08-22 13:43:25]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 13:43:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-22 14:51:00]

vabr@chromium.org changed reviewers:
+ dvadym@chromium.org

[vabr (Chromium), 2016-08-22 14:51:01]

Hi Vadym,

This is another CL in the series, could you please review it?

It is unfortunately big (take your time!), but quite mechanical. I'm of course
happy to chat about it if you have any questions.

Cheers,
Vaclav

[commit-bot: I haz the power, 2016-08-22 14:55:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 14:55:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[vabr (Chromium), 2016-08-22 15:03:25]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 15:03:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-22 15:25:49]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 15:25:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 15:34:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 15:34:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-08-23 08:18:50]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 08:19:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 10:24:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 10:24:12]

Dry run: This issue passed the CQ dry run.

[dvadym, 2016-08-23 17:02:20]

LGTM

https://codereview.chromium.org/2262843002/diff/200001/components/password_ma...
File components/password_manager/core/browser/password_form_manager.h (right):

https://codereview.chromium.org/2262843002/diff/200001/components/password_ma...
components/password_manager/core/browser/password_form_manager.h:474: // being
managed by this.
Do I understand correctly that *_owned variables will be removed from PFM as
soon as ownership of matches will be moved for Fetcher?

[vabr (Chromium), 2016-08-24 08:07:28]

Thanks, Vadym!
Vaclav

https://codereview.chromium.org/2262843002/diff/200001/components/password_ma...
File components/password_manager/core/browser/password_form_manager.h (right):

https://codereview.chromium.org/2262843002/diff/200001/components/password_ma...
components/password_manager/core/browser/password_form_manager.h:474: // being
managed by this.
On 2016/08/23 17:02:19, dvadym wrote:
> Do I understand correctly that *_owned variables will be removed from PFM as
> soon as ownership of matches will be moved for Fetcher?

Indeed! You can already see it here:
https://codereview.chromium.org/2252283005/, it's the next CL, and Vasilii is
currently reviewing it.

[vabr (Chromium), 2016-08-24 08:07:44]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-08-24 08:08:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 08:12:50]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-08-24 08:14:05]

Description was changed from

==========
Make PasswordFormManager::best_matches_ const

...and also the related lists of passwords from PasswordStore.
PasswordFormManager should not really modify them, and will not be able to do
so once their ownership will transfer to the coming FormFetcher, shared among
multiple PasswordFormManagers.

As a side-effect, this CL also gets rid of two aliases for maps involving
PasswordForm. While the map's signature is long, it is more helpful to spell it
out than to hide it behind a cryptic PasswordFormMap, or similar, which does
not hint on ownership involved in the map.

BUG=621355
==========

to

==========
Make PasswordFormManager::best_matches_ const

...and also the related lists of passwords from PasswordStore.
PasswordFormManager should not really modify them, and will not be able to do
so once their ownership will transfer to the coming FormFetcher, shared among
multiple PasswordFormManagers.

As a side-effect, this CL also gets rid of two aliases for maps involving
PasswordForm. While the map's signature is long, it is more helpful to spell it
out than to hide it behind a cryptic PasswordFormMap, or similar, which does
not hint on ownership involved in the map.

BUG=621355

Committed: https://crrev.com/a5406f79261a94c55b0826fac05f73375ded7d15
Cr-Commit-Position: refs/heads/master@{#414016}
==========

[commit-bot: I haz the power, 2016-08-24 08:14:06]

Patchset 11 (id:??) landed as
https://crrev.com/a5406f79261a94c55b0826fac05f73375ded7d15
Cr-Commit-Position: refs/heads/master@{#414016}