components/autofill/core/common/password_form_fill_data.cc - Issue 2262843002: Make PasswordFormManager::best_matches_ const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form_fill_data.cc

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value

Patch Set: Just rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/password_form_fill_data.h ('k') | components/autofill/core/common/password_form_fill_data_unittest.cc » ('j') | components/password_manager/core/browser/password_form_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form_fill_data.cc

diff --git a/components/autofill/core/common/password_form_fill_data.cc b/components/autofill/core/common/password_form_fill_data.cc

index 3ffa1811600ea63eb414424a52931ed2f0339413..b4d5fd047bcc70c13091f8a8d89c4d63bf1b78cb 100644

--- a/components/autofill/core/common/password_form_fill_data.cc

+++ b/components/autofill/core/common/password_form_fill_data.cc

@@ -34,7 +34,7 @@ PasswordFormFillData::~PasswordFormFillData() {

void InitPasswordFormFillData(

const PasswordForm& form_on_page,

- const PasswordFormMap& matches,

+ const std::map<base::string16, const PasswordForm*>& matches,

const PasswordForm* const preferred_match,

bool wait_for_username_before_autofill,

bool enable_other_possible_usernames,

@@ -66,7 +66,7 @@ void InitPasswordFormFillData(

// Copy additional username/value pairs.

for (const auto& it : matches) {

- if (it.second.get() != preferred_match) {

+ if (it.second != preferred_match) {

PasswordAndRealm value;

value.password = it.second->password_value;

if (it.second->is_public_suffix_match ||