Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value
Patch Set: Just rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 const GURL& origin) override; 66 const GURL& origin) override;
67 void NotifyUserCouldBeAutoSignedIn( 67 void NotifyUserCouldBeAutoSignedIn(
68 std::unique_ptr<autofill::PasswordForm> form) override; 68 std::unique_ptr<autofill::PasswordForm> form) override;
69 void NotifySuccessfulLoginWithExistingPassword( 69 void NotifySuccessfulLoginWithExistingPassword(
70 const autofill::PasswordForm& form) override; 70 const autofill::PasswordForm& form) override;
71 void NotifyStorePasswordCalled() override; 71 void NotifyStorePasswordCalled() override;
72 void AutomaticPasswordSave( 72 void AutomaticPasswordSave(
73 std::unique_ptr<password_manager::PasswordFormManager> saved_form_manager) 73 std::unique_ptr<password_manager::PasswordFormManager> saved_form_manager)
74 override; 74 override;
75 void PasswordWasAutofilled( 75 void PasswordWasAutofilled(
76 const autofill::PasswordFormMap& best_matches, 76 const std::map<base::string16, const autofill::PasswordForm*>&
77 best_matches,
77 const GURL& origin, 78 const GURL& origin,
78 const std::vector<std::unique_ptr<autofill::PasswordForm>>* 79 const std::vector<const autofill::PasswordForm*>* federated_matches)
79 federated_matches) const override; 80 const override;
80 PrefService* GetPrefs() override; 81 PrefService* GetPrefs() override;
81 password_manager::PasswordStore* GetPasswordStore() const override; 82 password_manager::PasswordStore* GetPasswordStore() const override;
82 password_manager::PasswordSyncState GetPasswordSyncState() const override; 83 password_manager::PasswordSyncState GetPasswordSyncState() const override;
83 bool WasLastNavigationHTTPError() const override; 84 bool WasLastNavigationHTTPError() const override;
84 bool DidLastPageLoadEncounterSSLErrors() const override; 85 bool DidLastPageLoadEncounterSSLErrors() const override;
85 bool IsOffTheRecord() const override; 86 bool IsOffTheRecord() const override;
86 const password_manager::PasswordManager* GetPasswordManager() const override; 87 const password_manager::PasswordManager* GetPasswordManager() const override;
87 autofill::AutofillManager* GetAutofillManagerForMainFrame() override; 88 autofill::AutofillManager* GetAutofillManagerForMainFrame() override;
88 const GURL& GetMainFrameURL() const override; 89 const GURL& GetMainFrameURL() const override;
89 bool IsUpdatePasswordUIEnabled() const override; 90 bool IsUpdatePasswordUIEnabled() const override;
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 std::unique_ptr<password_manager::LogManager> log_manager_; 191 std::unique_ptr<password_manager::LogManager> log_manager_;
191 192
192 // Set during 'NotifyUserCouldBeAutoSignedIn' in order to store the 193 // Set during 'NotifyUserCouldBeAutoSignedIn' in order to store the
193 // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'. 194 // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'.
194 std::unique_ptr<autofill::PasswordForm> possible_auto_sign_in_; 195 std::unique_ptr<autofill::PasswordForm> possible_auto_sign_in_;
195 196
196 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 197 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
197 }; 198 };
198 199
199 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 200 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698