Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value
Patch Set: Just rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <limits> 10 #include <limits>
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 password_manager::InteractionsStats interaction_stats; 209 password_manager::InteractionsStats interaction_stats;
210 if (state_ == password_manager::ui::PENDING_PASSWORD_STATE || 210 if (state_ == password_manager::ui::PENDING_PASSWORD_STATE ||
211 state_ == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) { 211 state_ == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) {
212 pending_password_ = delegate_->GetPendingPassword(); 212 pending_password_ = delegate_->GetPendingPassword();
213 if (state_ == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) { 213 if (state_ == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) {
214 local_credentials_ = DeepCopyForms(delegate_->GetCurrentForms()); 214 local_credentials_ = DeepCopyForms(delegate_->GetCurrentForms());
215 password_overridden_ = delegate_->IsPasswordOverridden(); 215 password_overridden_ = delegate_->IsPasswordOverridden();
216 } else { 216 } else {
217 interaction_stats.origin_domain = origin_.GetOrigin(); 217 interaction_stats.origin_domain = origin_.GetOrigin();
218 interaction_stats.username_value = pending_password_.username_value; 218 interaction_stats.username_value = pending_password_.username_value;
219 password_manager::InteractionsStats* stats = 219 const password_manager::InteractionsStats* stats =
220 delegate_->GetCurrentInteractionStats(); 220 delegate_->GetCurrentInteractionStats();
221 if (stats) { 221 if (stats) {
222 DCHECK_EQ(interaction_stats.username_value, stats->username_value); 222 DCHECK_EQ(interaction_stats.username_value, stats->username_value);
223 DCHECK_EQ(interaction_stats.origin_domain, stats->origin_domain); 223 DCHECK_EQ(interaction_stats.origin_domain, stats->origin_domain);
224 interaction_stats.dismissal_count = stats->dismissal_count; 224 interaction_stats.dismissal_count = stats->dismissal_count;
225 } 225 }
226 } 226 }
227 UpdatePendingStateTitle(); 227 UpdatePendingStateTitle();
228 } else if (state_ == password_manager::ui::CONFIRMATION_STATE) { 228 } else if (state_ == password_manager::ui::CONFIRMATION_STATE) {
229 title_ = 229 title_ =
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 return metrics_util::NO_UPDATE_SUBMISSION; 501 return metrics_util::NO_UPDATE_SUBMISSION;
502 } 502 }
503 if (state_ != password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) 503 if (state_ != password_manager::ui::PENDING_PASSWORD_UPDATE_STATE)
504 return metrics_util::NO_UPDATE_SUBMISSION; 504 return metrics_util::NO_UPDATE_SUBMISSION;
505 if (password_overridden_) 505 if (password_overridden_)
506 return update_events[3][behavior]; 506 return update_events[3][behavior];
507 if (ShouldShowMultipleAccountUpdateUI()) 507 if (ShouldShowMultipleAccountUpdateUI())
508 return update_events[2][behavior]; 508 return update_events[2][behavior];
509 return update_events[1][behavior]; 509 return update_events[1][behavior];
510 } 510 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698