Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value
Patch Set: Just rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index 3ea1499f5d4774b5ee8ec42abd448319ae2afa30..299ac6d7f3bf35a018d227b28dc2a177ece08687 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -141,10 +141,11 @@ class PasswordManagerClient {
// They are never filled, but might be needed in the UI, for example. Default
// implementation is a noop.
virtual void PasswordWasAutofilled(
- const autofill::PasswordFormMap& best_matches,
+ const std::map<base::string16, const autofill::PasswordForm*>&
+ best_matches,
const GURL& origin,
- const std::vector<std::unique_ptr<autofill::PasswordForm>>*
- federated_matches) const;
+ const std::vector<const autofill::PasswordForm*>* federated_matches)
+ const;
// Gets prefs associated with this embedder.
virtual PrefService* GetPrefs() = 0;

Powered by Google App Engine
This is Rietveld 408576698