components/password_manager/core/browser/stub_form_saver.h - Issue 2262843002: Make PasswordFormManager::best_matches_ const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/stub_form_saver.h

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value

Patch Set: Just rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager.h ('K') | « components/password_manager/core/browser/statistics_table.cc ('k') | ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/stub_form_saver.h

diff --git a/components/password_manager/core/browser/stub_form_saver.h b/components/password_manager/core/browser/stub_form_saver.h

index cbd72af10cb709d8914d741ab74cfa4a004ffba7..5efa6834424f0ff02cafbc3bf460baa355fea632 100644

--- a/components/password_manager/core/browser/stub_form_saver.h

+++ b/components/password_manager/core/browser/stub_form_saver.h

@@ -20,10 +20,12 @@ class StubFormSaver : public FormSaver {

// FormSaver:

void PermanentlyBlacklist(autofill::PasswordForm* observed) override {}

void Save(const autofill::PasswordForm& pending,

- const autofill::PasswordFormMap& best_matches,

+ const std::map<base::string16, const autofill::PasswordForm*>&

+ best_matches,

const autofill::PasswordForm* old_primary_key) override {}

void Update(const autofill::PasswordForm& pending,

- const autofill::PasswordFormMap& best_matches,

+ const std::map<base::string16, const autofill::PasswordForm*>&

+ best_matches,

const std::vector<autofill::PasswordForm>* credentials_to_update,

const autofill::PasswordForm* old_primary_key) override {}

void PresaveGeneratedPassword(

@@ -31,7 +33,7 @@ class StubFormSaver : public FormSaver {

void RemovePresavedPassword() override {}

void WipeOutdatedCopies(

const autofill::PasswordForm& pending,

- autofill::PasswordFormMap* best_matches,

+ std::map<base::string16, const autofill::PasswordForm*>* best_matches,

const autofill::PasswordForm** preferred_match) override {}

private: