Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.h

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value
Patch Set: Just rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_state.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_state.h b/chrome/browser/ui/passwords/manage_passwords_state.h
index 52c0c30a3717d938aad2ae427294b292b446fbed..30348c5cde238850100b07238807510c02b30986 100644
--- a/chrome/browser/ui/passwords/manage_passwords_state.h
+++ b/chrome/browser/ui/passwords/manage_passwords_state.h
@@ -5,11 +5,13 @@
#ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_STATE_H_
#define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_STATE_H_
+#include <map>
#include <memory>
#include <vector>
#include "base/callback.h"
#include "base/macros.h"
+#include "base/strings/string16.h"
#include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/password_store_change.h"
#include "components/password_manager/core/common/credential_manager_types.h"
@@ -69,10 +71,10 @@ class ManagePasswordsState {
// autofilled. In addition, |federated_matches|, if not null, contains stored
// federated credentials to show to the user as well.
void OnPasswordAutofilled(
- const autofill::PasswordFormMap& password_form_map,
+ const std::map<base::string16, const autofill::PasswordForm*>&
+ password_form_map,
const GURL& origin,
- const std::vector<std::unique_ptr<autofill::PasswordForm>>*
- federated_matches);
+ const std::vector<const autofill::PasswordForm*>* federated_matches);
// Move to INACTIVE_STATE.
void OnInactive();

Powered by Google App Engine
This is Rietveld 408576698