components/password_manager/core/browser/password_manager.cc - Issue 2262843002: Make PasswordFormManager::best_matches_ const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value

Patch Set: Just rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager.h ('K') | « components/password_manager/core/browser/password_manager.h ('k') | components/password_manager/core/browser/password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index d3d2d587a23587951aec18c9f98dc372348e66c2..07ed300bf6b975ac929425eb739fe91778f0004c 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -41,7 +41,6 @@

#endif

using autofill::PasswordForm;

-using autofill::PasswordFormMap;

namespace password_manager {

@@ -739,8 +738,8 @@ bool PasswordManager::OtherPossibleUsernamesEnabled() const {

void PasswordManager::Autofill(

password_manager::PasswordManagerDriver* driver,

const PasswordForm& form_for_autofill,

- const PasswordFormMap& best_matches,

- const std::vector<std::unique_ptr<PasswordForm>>& federated_matches,

+ const std::map<base::string16, const PasswordForm*>& best_matches,

+ const std::vector<const PasswordForm*>& federated_matches,

const PasswordForm& preferred_match,

bool wait_for_username) const {

DCHECK_EQ(PasswordForm::SCHEME_HTML, preferred_match.scheme);

@@ -772,8 +771,7 @@ void PasswordManager::Autofill(

void PasswordManager::ShowInitialPasswordAccountSuggestions(

password_manager::PasswordManagerDriver* driver,

const PasswordForm& form_for_autofill,

- const PasswordFormMap& best_matches,

- const std::vector<std::unique_ptr<PasswordForm>>& federated_matches,

+ const std::map<base::string16, const PasswordForm*>& best_matches,

const PasswordForm& preferred_match,

bool wait_for_username) const {

DCHECK_EQ(PasswordForm::SCHEME_HTML, preferred_match.scheme);

@@ -796,7 +794,7 @@ void PasswordManager::ShowInitialPasswordAccountSuggestions(

}

void PasswordManager::AutofillHttpAuth(

- const PasswordFormMap& best_matches,

+ const std::map<base::string16, const PasswordForm*>& best_matches,

const PasswordForm& preferred_match) const {

DCHECK_NE(PasswordForm::SCHEME_HTML, preferred_match.scheme);