chrome/browser/ui/passwords/manage_passwords_test.cc - Issue 2262843002: Make PasswordFormManager::best_matches_ const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_test.cc

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value

Patch Set: Just rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state_unittest.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | components/password_manager/core/browser/password_form_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_test.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_test.cc b/chrome/browser/ui/passwords/manage_passwords_test.cc

index dbd8915c231cbf73db725482026f84026bc797ba..4aea89a69d02199383d3d3a40d86b1d428535c52 100644

--- a/chrome/browser/ui/passwords/manage_passwords_test.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_test.cc

@@ -4,10 +4,12 @@

#include "chrome/browser/ui/passwords/manage_passwords_test.h"

+#include <map>

#include <utility>

#include "base/bind.h"

#include "base/memory/ptr_util.h"

+#include "base/strings/string16.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/ui/browser.h"

@@ -48,10 +50,8 @@ void ManagePasswordsTest::ExecuteManagePasswordsCommand() {

void ManagePasswordsTest::SetupManagingPasswords() {

base::string16 kTestUsername = base::ASCIIToUTF16("test_username");

- autofill::PasswordFormMap map;

- map.insert(std::make_pair(

- kTestUsername,

- base::WrapUnique(new autofill::PasswordForm(*test_form()))));

+ std::map<base::string16, const autofill::PasswordForm*> map;

+ map.insert(std::make_pair(kTestUsername, test_form()));

GetController()->OnPasswordAutofilled(map, map.begin()->second->origin,

nullptr);

}