components/autofill/core/common/password_form.h - Issue 2262843002: Make PasswordFormManager::best_matches_ const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form.h

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value

Patch Set: Just rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/passwords_model_delegate.h ('k') | components/autofill/core/common/password_form_fill_data.h » ('j') | components/password_manager/core/browser/password_form_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form.h

diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h

index a32e530842c0316a0419e91f758da4ea2d73a8c4..c70da901fc9ede05611b61e3f8f37842678666e0 100644

--- a/components/autofill/core/common/password_form.h

+++ b/components/autofill/core/common/password_form.h

@@ -296,12 +296,6 @@ struct LessThanUniqueKey {

bool operator()(const PasswordForm* left, const PasswordForm* right) const;

};

-// Map username to PasswordForm* for convenience. See password_form_manager.h.

-using PasswordFormMap = std::map<base::string16, std::unique_ptr<PasswordForm>>;

-// Like PasswordFormMap, but with weak (not owned) pointers.

-using ConstPasswordFormMap = std::map<base::string16, const PasswordForm*>;

// For testing.

std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout);

std::ostream& operator<<(std::ostream& os, const PasswordForm& form);