Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value
Patch Set: Just rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index b373a02304a9bbaffe782c2eb33564a207b52b98..7962b97d5580f4fe5fd0159b77c804cffe1c99af 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -353,10 +353,9 @@ void ChromePasswordManagerClient::AutomaticPasswordSave(
}
void ChromePasswordManagerClient::PasswordWasAutofilled(
- const autofill::PasswordFormMap& best_matches,
+ const std::map<base::string16, const autofill::PasswordForm*>& best_matches,
const GURL& origin,
- const std::vector<std::unique_ptr<autofill::PasswordForm>>*
- federated_matches) const {
+ const std::vector<const autofill::PasswordForm*>* federated_matches) const {
#if !BUILDFLAG(ANDROID_JAVA_UI)
PasswordsClientUIDelegate* manage_passwords_ui_controller =
PasswordsClientUIDelegateFromWebContents(web_contents());

Powered by Google App Engine
This is Rietveld 408576698