chrome/browser/ui/passwords/manage_passwords_ui_controller.h - Issue 2262843002: Make PasswordFormManager::best_matches_ const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value

Patch Set: Just rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_test.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | components/password_manager/core/browser/password_form_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

index 3188de8e038f77ded362ea2b529d41841880c14f..ed0f2b171c17cfa76fc8a6dd62821d93a68c037c 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

@@ -65,10 +65,11 @@ class ManagePasswordsUIController

std::unique_ptr<password_manager::PasswordFormManager> form_manager)

override;

void OnPasswordAutofilled(

- const autofill::PasswordFormMap& password_form_map,

+ const std::map<base::string16, const autofill::PasswordForm*>&

+ password_form_map,

const GURL& origin,

- const std::vector<std::unique_ptr<autofill::PasswordForm>>*

- federated_matches) override;

+ const std::vector<const autofill::PasswordForm*>* federated_matches)

+ override;

// PasswordStore::Observer:

void OnLoginsChanged(

@@ -94,8 +95,8 @@ class ManagePasswordsUIController

const override;

const std::vector<std::unique_ptr<autofill::PasswordForm>>&

GetFederatedForms() const override;

- password_manager::InteractionsStats* GetCurrentInteractionStats() const

- override;

+ const password_manager::InteractionsStats* GetCurrentInteractionStats()

+ const override;

void OnBubbleShown() override;

void OnBubbleHidden() override;

void OnNoInteractionOnUpdate() override;