components/password_manager/core/browser/password_manager_client.cc - Issue 2262843002: Make PasswordFormManager::best_matches_ const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 2262843002: Make PasswordFormManager::best_matches_ const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_pass_creds_to_update_by_value

Patch Set: Just rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager.h ('K') | « components/password_manager/core/browser/password_manager_client.h ('k') | components/password_manager/core/browser/statistics_table.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_client.cc

diff --git a/components/password_manager/core/browser/password_manager_client.cc b/components/password_manager/core/browser/password_manager_client.cc

index a2ea65c68adcb6540c94f84fc9ab639ad0ffd0e9..fa15795f76417cccb6ef8f389261d7ca57ec4e6e 100644

--- a/components/password_manager/core/browser/password_manager_client.cc

+++ b/components/password_manager/core/browser/password_manager_client.cc

@@ -25,10 +25,10 @@ void PasswordManagerClient::ForceSavePassword() {

void PasswordManagerClient::GeneratePassword() {}

void PasswordManagerClient::PasswordWasAutofilled(

- const autofill::PasswordFormMap& best_matches,

+ const std::map<base::string16, const autofill::PasswordForm*>& best_matches,

const GURL& origin,

- const std::vector<std::unique_ptr<autofill::PasswordForm>>*

- federated_matches) const {}

+ const std::vector<const autofill::PasswordForm*>* federated_matches) const {

PasswordSyncState PasswordManagerClient::GetPasswordSyncState() const {

return NOT_SYNCING_PASSWORDS;