Avoid accessing Isolate in source position logging.

Avoid accessing Isolate in source position logging.

Now that all backends use the source position builder to record source
positions, simplify the code line logging events to take a source
position table on code creation. This means that the source position
table builder no longer needs to access the isolate until the table is
generated. This is required for off-thread bytecode generation.

BUG=v8:5203
Committed: https://crrev.com/b8b4a443b8e7707ada2328af8158e5c14c0198a9
Cr-Commit-Position: refs/heads/master@{#38676}

[rmcilroy, 2016-08-15 12:24:17]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 12:24:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-08-15 12:40:54]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2016-08-15 12:41:03]

Patchset #1 (id:20001) has been deleted

[rmcilroy, 2016-08-15 12:41:15]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 12:41:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-08-15 12:43:03]

rmcilroy@chromium.org changed reviewers:
+ bmeurer@chromium.org, jgruber@chromium.org

[rmcilroy, 2016-08-15 12:43:03]

jgruber@ for debug/, log.* and source position changes.
bmeurer@ for backends.
ahaas@ FYI (might be useful for your efforts to make code-gen off-thread).

[commit-bot: I haz the power, 2016-08-15 13:05:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 13:05:18]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-08-16 07:46:15]

lgtm

[rmcilroy, 2016-08-16 09:19:31]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org, verwaest@google.com
- bmeurer@chromium.org

[rmcilroy, 2016-08-16 09:19:32]

+Toon for Crankshaft
+Michi for other backends.

PTAL, thanks.

[rmcilroy, 2016-08-16 09:20:15]

rmcilroy@chromium.org changed reviewers:
+ verwaest@chromium.org
- verwaest@google.com

[rmcilroy, 2016-08-16 09:20:16]

+Toon's Chromium account

[Michael Starzinger, 2016-08-16 09:28:05]

LGTM from my end. I like it.

[Toon Verwaest, 2016-08-16 19:45:22]

Oh my, the code is readable.
lgtm

[rmcilroy, 2016-08-17 09:06:19]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-08-17 09:06:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 09:31:30]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-08-17 09:31:48]

Description was changed from

==========
Avoid accessing Isolate in source position logging.

Now that all backends use the source position builder to record source
positions, simplify the code line logging events to take a source
position table on code creation. This means that the source position
table builder no longer needs to access the isolate until the table is
generated. This is required for off-thread bytecode generation.

BUG=v8:5203
==========

to

==========
Avoid accessing Isolate in source position logging.

Now that all backends use the source position builder to record source
positions, simplify the code line logging events to take a source
position table on code creation. This means that the source position
table builder no longer needs to access the isolate until the table is
generated. This is required for off-thread bytecode generation.

BUG=v8:5203

Committed: https://crrev.com/b8b4a443b8e7707ada2328af8158e5c14c0198a9
Cr-Commit-Position: refs/heads/master@{#38676}
==========

[commit-bot: I haz the power, 2016-08-17 09:31:49]

Patchset 2 (id:??) landed as
https://crrev.com/b8b4a443b8e7707ada2328af8158e5c14c0198a9
Cr-Commit-Position: refs/heads/master@{#38676}