Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: src/crankshaft/x87/lithium-codegen-x87.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x64/lithium-codegen-x64.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/crankshaft/x87/lithium-codegen-x87.h" 7 #include "src/crankshaft/x87/lithium-codegen-x87.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 GenerateDeferredCode() && 61 GenerateDeferredCode() &&
62 GenerateJumpTable() && 62 GenerateJumpTable() &&
63 GenerateSafepointTable(); 63 GenerateSafepointTable();
64 } 64 }
65 65
66 66
67 void LCodeGen::FinishCode(Handle<Code> code) { 67 void LCodeGen::FinishCode(Handle<Code> code) {
68 DCHECK(is_done()); 68 DCHECK(is_done());
69 code->set_stack_slots(GetTotalFrameSlotCount()); 69 code->set_stack_slots(GetTotalFrameSlotCount());
70 code->set_safepoint_table_offset(safepoints_.GetCodeOffset()); 70 code->set_safepoint_table_offset(safepoints_.GetCodeOffset());
71 Handle<ByteArray> source_positions =
72 source_position_table_builder_.ToSourcePositionTable();
73 code->set_source_position_table(*source_positions);
74 PopulateDeoptimizationData(code); 71 PopulateDeoptimizationData(code);
75 if (info()->ShouldEnsureSpaceForLazyDeopt()) { 72 if (info()->ShouldEnsureSpaceForLazyDeopt()) {
76 Deoptimizer::EnsureRelocSpaceForLazyDeoptimization(code); 73 Deoptimizer::EnsureRelocSpaceForLazyDeoptimization(code);
77 } 74 }
78 } 75 }
79 76
80 77
81 #ifdef _MSC_VER 78 #ifdef _MSC_VER
82 void LCodeGen::MakeSureStackPagesMapped(int offset) { 79 void LCodeGen::MakeSureStackPagesMapped(int offset) {
83 const int kPageSize = 4 * KB; 80 const int kPageSize = 4 * KB;
(...skipping 5687 matching lines...) Expand 10 before | Expand all | Expand 10 after
5771 __ bind(deferred->exit()); 5768 __ bind(deferred->exit());
5772 __ bind(&done); 5769 __ bind(&done);
5773 } 5770 }
5774 5771
5775 #undef __ 5772 #undef __
5776 5773
5777 } // namespace internal 5774 } // namespace internal
5778 } // namespace v8 5775 } // namespace v8
5779 5776
5780 #endif // V8_TARGET_ARCH_X87 5777 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/crankshaft/x64/lithium-codegen-x64.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698