Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/s390/lithium-codegen-s390.cc ('k') | src/crankshaft/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/crankshaft/x64/lithium-codegen-x64.h" 7 #include "src/crankshaft/x64/lithium-codegen-x64.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 GenerateDeferredCode() && 59 GenerateDeferredCode() &&
60 GenerateJumpTable() && 60 GenerateJumpTable() &&
61 GenerateSafepointTable(); 61 GenerateSafepointTable();
62 } 62 }
63 63
64 64
65 void LCodeGen::FinishCode(Handle<Code> code) { 65 void LCodeGen::FinishCode(Handle<Code> code) {
66 DCHECK(is_done()); 66 DCHECK(is_done());
67 code->set_stack_slots(GetTotalFrameSlotCount()); 67 code->set_stack_slots(GetTotalFrameSlotCount());
68 code->set_safepoint_table_offset(safepoints_.GetCodeOffset()); 68 code->set_safepoint_table_offset(safepoints_.GetCodeOffset());
69 Handle<ByteArray> source_positions =
70 source_position_table_builder_.ToSourcePositionTable();
71 code->set_source_position_table(*source_positions);
72 PopulateDeoptimizationData(code); 69 PopulateDeoptimizationData(code);
73 } 70 }
74 71
75 72
76 #ifdef _MSC_VER 73 #ifdef _MSC_VER
77 void LCodeGen::MakeSureStackPagesMapped(int offset) { 74 void LCodeGen::MakeSureStackPagesMapped(int offset) {
78 const int kPageSize = 4 * KB; 75 const int kPageSize = 4 * KB;
79 for (offset -= kPageSize; offset > 0; offset -= kPageSize) { 76 for (offset -= kPageSize; offset > 0; offset -= kPageSize) {
80 __ movp(Operand(rsp, offset), rax); 77 __ movp(Operand(rsp, offset), rax);
81 } 78 }
(...skipping 5485 matching lines...) Expand 10 before | Expand all | Expand 10 after
5567 __ bind(deferred->exit()); 5564 __ bind(deferred->exit());
5568 __ bind(&done); 5565 __ bind(&done);
5569 } 5566 }
5570 5567
5571 #undef __ 5568 #undef __
5572 5569
5573 } // namespace internal 5570 } // namespace internal
5574 } // namespace v8 5571 } // namespace v8
5575 5572
5576 #endif // V8_TARGET_ARCH_X64 5573 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/crankshaft/s390/lithium-codegen-s390.cc ('k') | src/crankshaft/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698