Avoid accessing Isolate in source position logging.

src/debug/liveedit.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/debug/liveedit.h"
 
 #include "src/ast/scopes.h"
 #include "src/code-stubs.h"
 #include "src/compilation-cache.h"
 #include "src/compiler.h"
@@ skipping 1084 matching lines @@
     element = JSReceiver::GetElement(isolate, position_change_array, i + 2)
                   .ToHandleChecked();
     CHECK(element->IsSmi());
     int chunk_changed_end = Handle<Smi>::cast(element)->value();
     position_diff = chunk_changed_end - chunk_end;
   }
 
   return original_position + position_diff;
 }
 
-Handle<ByteArray> TranslateSourcePositionTable(
-    Handle<ByteArray> source_position_table,
-    Handle<JSArray> position_change_array) {
-  Isolate* isolate = source_position_table->GetIsolate();
+void TranslateSourcePositionTable(Handle<AbstractCode> code,
+                                  Handle<JSArray> position_change_array) {
+  Isolate* isolate = code->GetIsolate();
   Zone zone(isolate->allocator());
-  SourcePositionTableBuilder builder(isolate, &zone);
+  SourcePositionTableBuilder builder(&zone);
 
+  Handle<ByteArray> source_position_table(code->source_position_table());
   for (SourcePositionTableIterator iterator(*source_position_table);
        !iterator.done(); iterator.Advance()) {
     int position = iterator.source_position();
     int new_position = TranslatePosition(position, position_change_array);
     builder.AddPosition(iterator.code_offset(), new_position,
                         iterator.is_statement());
   }
 
-  return builder.ToSourcePositionTable();
+  Handle<ByteArray> new_source_position_table(
+      builder.ToSourcePositionTable(isolate, code));
+  code->set_source_position_table(*new_source_position_table);
 }
 }  // namespace
 
 void LiveEdit::PatchFunctionPositions(Handle<JSArray> shared_info_array,
                                       Handle<JSArray> position_change_array) {
   SharedInfoWrapper shared_info_wrapper(shared_info_array);
   Handle<SharedFunctionInfo> info = shared_info_wrapper.GetInfo();
 
   int old_function_start = info->start_position();
   int new_function_start = TranslatePosition(old_function_start,
                                              position_change_array);
   int new_function_end = TranslatePosition(info->end_position(),
                                            position_change_array);
   int new_function_token_pos =
       TranslatePosition(info->function_token_position(), position_change_array);
 
   info->set_start_position(new_function_start);
   info->set_end_position(new_function_end);
   info->set_function_token_position(new_function_token_pos);
 
   if (info->HasBytecodeArray()) {
-    Handle<ByteArray> new_source_position_table = TranslateSourcePositionTable(
-        Handle<ByteArray>(info->bytecode_array()->source_position_table()),
+    TranslateSourcePositionTable(
+        Handle<AbstractCode>(AbstractCode::cast(info->bytecode_array())),
         position_change_array);
-    info->bytecode_array()->set_source_position_table(
-        *new_source_position_table);
   }
   if (info->code()->kind() == Code::FUNCTION) {
-    Handle<ByteArray> new_source_position_table = TranslateSourcePositionTable(
-        Handle<ByteArray>(info->code()->source_position_table()),
+    TranslateSourcePositionTable(
+        Handle<AbstractCode>(AbstractCode::cast(info->code())),
         position_change_array);
-    info->code()->set_source_position_table(*new_source_position_table);
   }
   if (info->HasDebugInfo()) {
     // Existing break points will be re-applied. Reset the debug info here.
     info->GetIsolate()->debug()->RemoveDebugInfoAndClearFromShared(
         handle(info->GetDebugInfo()));
   }
 }
 
 
 static Handle<Script> CreateScriptCopy(Handle<Script> original) {
@@ skipping 760 matching lines @@
     scope_info_length++;
 
     current_scope = current_scope->outer_scope();
   }
 
   return scope_info_list;
 }
 
 }  // namespace internal
 }  // namespace v8