Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: src/crankshaft/lithium.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/ia32/lithium-codegen-ia32.cc ('k') | src/crankshaft/lithium-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/lithium.h" 5 #include "src/crankshaft/lithium.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 8
9 #if V8_TARGET_ARCH_IA32 9 #if V8_TARGET_ARCH_IA32
10 #include "src/crankshaft/ia32/lithium-ia32.h" // NOLINT 10 #include "src/crankshaft/ia32/lithium-ia32.h" // NOLINT
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 454
455 MarkEmptyBlocks(); 455 MarkEmptyBlocks();
456 456
457 if (generator.GenerateCode()) { 457 if (generator.GenerateCode()) {
458 generator.CheckEnvironmentUsage(); 458 generator.CheckEnvironmentUsage();
459 CodeGenerator::MakeCodePrologue(info(), "optimized"); 459 CodeGenerator::MakeCodePrologue(info(), "optimized");
460 Handle<Code> code = CodeGenerator::MakeCodeEpilogue( 460 Handle<Code> code = CodeGenerator::MakeCodeEpilogue(
461 &assembler, nullptr, info(), assembler.CodeObject()); 461 &assembler, nullptr, info(), assembler.CodeObject());
462 generator.FinishCode(code); 462 generator.FinishCode(code);
463 CommitDependencies(code); 463 CommitDependencies(code);
464 generator.source_position_table_builder()->EndJitLogging( 464 Handle<ByteArray> source_positions =
465 AbstractCode::cast(*code)); 465 generator.source_position_table_builder()->ToSourcePositionTable(
466 info()->isolate(), Handle<AbstractCode>::cast(code));
467 code->set_source_position_table(*source_positions);
466 code->set_is_crankshafted(true); 468 code->set_is_crankshafted(true);
467 469
468 CodeGenerator::PrintCode(code, info()); 470 CodeGenerator::PrintCode(code, info());
469 DCHECK(!(info()->GetMustNotHaveEagerFrame() && 471 DCHECK(!(info()->GetMustNotHaveEagerFrame() &&
470 generator.NeedsEagerFrame())); 472 generator.NeedsEagerFrame()));
471 return code; 473 return code;
472 } 474 }
473 assembler.AbortedCodeGeneration(); 475 assembler.AbortedCodeGeneration();
474 return Handle<Code>::null(); 476 return Handle<Code>::null();
475 } 477 }
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
720 722
721 LPhase::~LPhase() { 723 LPhase::~LPhase() {
722 if (ShouldProduceTraceOutput()) { 724 if (ShouldProduceTraceOutput()) {
723 isolate()->GetHTracer()->TraceLithium(name(), chunk_); 725 isolate()->GetHTracer()->TraceLithium(name(), chunk_);
724 } 726 }
725 } 727 }
726 728
727 729
728 } // namespace internal 730 } // namespace internal
729 } // namespace v8 731 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/ia32/lithium-codegen-ia32.cc ('k') | src/crankshaft/lithium-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698