Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: src/crankshaft/arm/lithium-codegen-arm.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/crankshaft/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm/lithium-codegen-arm.h" 5 #include "src/crankshaft/arm/lithium-codegen-arm.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/crankshaft/arm/lithium-gap-resolver-arm.h" 10 #include "src/crankshaft/arm/lithium-gap-resolver-arm.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 return GeneratePrologue() && GenerateBody() && GenerateDeferredCode() && 54 return GeneratePrologue() && GenerateBody() && GenerateDeferredCode() &&
55 GenerateJumpTable() && GenerateSafepointTable(); 55 GenerateJumpTable() && GenerateSafepointTable();
56 } 56 }
57 57
58 58
59 void LCodeGen::FinishCode(Handle<Code> code) { 59 void LCodeGen::FinishCode(Handle<Code> code) {
60 DCHECK(is_done()); 60 DCHECK(is_done());
61 code->set_stack_slots(GetTotalFrameSlotCount()); 61 code->set_stack_slots(GetTotalFrameSlotCount());
62 code->set_safepoint_table_offset(safepoints_.GetCodeOffset()); 62 code->set_safepoint_table_offset(safepoints_.GetCodeOffset());
63 Handle<ByteArray> source_positions =
64 source_position_table_builder_.ToSourcePositionTable();
65 code->set_source_position_table(*source_positions);
66 PopulateDeoptimizationData(code); 63 PopulateDeoptimizationData(code);
67 } 64 }
68 65
69 66
70 void LCodeGen::SaveCallerDoubles() { 67 void LCodeGen::SaveCallerDoubles() {
71 DCHECK(info()->saves_caller_doubles()); 68 DCHECK(info()->saves_caller_doubles());
72 DCHECK(NeedsEagerFrame()); 69 DCHECK(NeedsEagerFrame());
73 Comment(";;; Save clobbered callee double registers"); 70 Comment(";;; Save clobbered callee double registers");
74 int count = 0; 71 int count = 0;
75 BitVector* doubles = chunk()->allocated_double_registers(); 72 BitVector* doubles = chunk()->allocated_double_registers();
(...skipping 5450 matching lines...) Expand 10 before | Expand all | Expand 10 after
5526 __ ldr(result, FieldMemOperand(scratch, 5523 __ ldr(result, FieldMemOperand(scratch,
5527 FixedArray::kHeaderSize - kPointerSize)); 5524 FixedArray::kHeaderSize - kPointerSize));
5528 __ bind(deferred->exit()); 5525 __ bind(deferred->exit());
5529 __ bind(&done); 5526 __ bind(&done);
5530 } 5527 }
5531 5528
5532 #undef __ 5529 #undef __
5533 5530
5534 } // namespace internal 5531 } // namespace internal
5535 } // namespace v8 5532 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/crankshaft/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698