Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: src/crankshaft/lithium.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/ia32/lithium-codegen-ia32.cc ('k') | src/crankshaft/lithium-codegen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/lithium.cc
diff --git a/src/crankshaft/lithium.cc b/src/crankshaft/lithium.cc
index 8ba35138c7a5bac4cc8b099bfb1c877a06100e7f..8cf3a3f0e6a982a497939e3caf08a48cdf8c6f11 100644
--- a/src/crankshaft/lithium.cc
+++ b/src/crankshaft/lithium.cc
@@ -461,8 +461,10 @@ Handle<Code> LChunk::Codegen() {
&assembler, nullptr, info(), assembler.CodeObject());
generator.FinishCode(code);
CommitDependencies(code);
- generator.source_position_table_builder()->EndJitLogging(
- AbstractCode::cast(*code));
+ Handle<ByteArray> source_positions =
+ generator.source_position_table_builder()->ToSourcePositionTable(
+ info()->isolate(), Handle<AbstractCode>::cast(code));
+ code->set_source_position_table(*source_positions);
code->set_is_crankshafted(true);
CodeGenerator::PrintCode(code, info());
« no previous file with comments | « src/crankshaft/ia32/lithium-codegen-ia32.cc ('k') | src/crankshaft/lithium-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698