Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: test/unittests/interpreter/bytecode-array-writer-unittest.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/source-position-table.cc ('k') | test/unittests/source-position-table-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/interpreter/bytecode-array-writer-unittest.cc
diff --git a/test/unittests/interpreter/bytecode-array-writer-unittest.cc b/test/unittests/interpreter/bytecode-array-writer-unittest.cc
index 7cca861247d20737c304551f18417e64d2e74e4d..11a3fde256ce04afc790d9f96248650e19cfa38e 100644
--- a/test/unittests/interpreter/bytecode-array-writer-unittest.cc
+++ b/test/unittests/interpreter/bytecode-array-writer-unittest.cc
@@ -235,9 +235,10 @@ TEST_F(BytecodeArrayWriterUnittest, ComplexExample) {
static_cast<int>(expected_bytes[i]));
}
- Handle<ByteArray> source_positions =
- source_position_table_builder()->ToSourcePositionTable();
- SourcePositionTableIterator source_iterator(*source_positions);
+ Handle<BytecodeArray> bytecode_array =
+ writer()->ToBytecodeArray(0, 0, factory()->empty_fixed_array());
+ SourcePositionTableIterator source_iterator(
+ bytecode_array->source_position_table());
for (size_t i = 0; i < arraysize(expected_positions); ++i) {
const PositionTableEntry& expected = expected_positions[i];
CHECK_EQ(source_iterator.code_offset(), expected.code_offset);
« no previous file with comments | « src/source-position-table.cc ('k') | test/unittests/source-position-table-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698