src/crankshaft/lithium-codegen.cc - Issue 2248673002: Avoid accessing Isolate in source position logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/lithium-codegen.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/lithium-codegen.cc

diff --git a/src/crankshaft/lithium-codegen.cc b/src/crankshaft/lithium-codegen.cc

index 7e8e92722b2275db44ffb4ec640d64f2d8509671..5041de6451f01cef793b83d6f2be7f30b3f7846f 100644

--- a/src/crankshaft/lithium-codegen.cc

+++ b/src/crankshaft/lithium-codegen.cc

@@ -63,7 +63,7 @@ LCodeGenBase::LCodeGenBase(LChunk* chunk, MacroAssembler* assembler,

inlined_function_count_(0),

last_lazy_deopt_pc_(0),

osr_pc_offset_(-1),

- source_position_table_builder_(info->isolate(), info->zone(),

+ source_position_table_builder_(info->zone(),

info->SourcePositionRecordingMode()) {}

bool LCodeGenBase::GenerateBody() {

« no previous file with comments | « src/crankshaft/lithium.cc ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »