Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/objects-inl.h

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/source-position-table.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5322 matching lines...) Expand 10 before | Expand all | Expand 10 after
5333 } 5333 }
5334 5334
5335 ByteArray* AbstractCode::source_position_table() { 5335 ByteArray* AbstractCode::source_position_table() {
5336 if (IsCode()) { 5336 if (IsCode()) {
5337 return GetCode()->source_position_table(); 5337 return GetCode()->source_position_table();
5338 } else { 5338 } else {
5339 return GetBytecodeArray()->source_position_table(); 5339 return GetBytecodeArray()->source_position_table();
5340 } 5340 }
5341 } 5341 }
5342 5342
5343 void AbstractCode::set_source_position_table(ByteArray* source_position_table) {
5344 if (IsCode()) {
5345 GetCode()->set_source_position_table(source_position_table);
5346 } else {
5347 GetBytecodeArray()->set_source_position_table(source_position_table);
5348 }
5349 }
5350
5343 int AbstractCode::LookupRangeInHandlerTable( 5351 int AbstractCode::LookupRangeInHandlerTable(
5344 int code_offset, int* data, HandlerTable::CatchPrediction* prediction) { 5352 int code_offset, int* data, HandlerTable::CatchPrediction* prediction) {
5345 if (IsCode()) { 5353 if (IsCode()) {
5346 return GetCode()->LookupRangeInHandlerTable(code_offset, data, prediction); 5354 return GetCode()->LookupRangeInHandlerTable(code_offset, data, prediction);
5347 } else { 5355 } else {
5348 return GetBytecodeArray()->LookupRangeInHandlerTable(code_offset, data, 5356 return GetBytecodeArray()->LookupRangeInHandlerTable(code_offset, data,
5349 prediction); 5357 prediction);
5350 } 5358 }
5351 } 5359 }
5352 5360
(...skipping 2855 matching lines...) Expand 10 before | Expand all | Expand 10 after
8208 #undef WRITE_INT64_FIELD 8216 #undef WRITE_INT64_FIELD
8209 #undef READ_BYTE_FIELD 8217 #undef READ_BYTE_FIELD
8210 #undef WRITE_BYTE_FIELD 8218 #undef WRITE_BYTE_FIELD
8211 #undef NOBARRIER_READ_BYTE_FIELD 8219 #undef NOBARRIER_READ_BYTE_FIELD
8212 #undef NOBARRIER_WRITE_BYTE_FIELD 8220 #undef NOBARRIER_WRITE_BYTE_FIELD
8213 8221
8214 } // namespace internal 8222 } // namespace internal
8215 } // namespace v8 8223 } // namespace v8
8216 8224
8217 #endif // V8_OBJECTS_INL_H_ 8225 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/source-position-table.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698