Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: src/full-codegen/full-codegen.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/interpreter/bytecode-array-writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/full-codegen.cc
diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc
index a4274f5abf2ce7b324e4030e44e5e775e8a43f8f..d83a23b3f8f72810896634712042b74ed55ce498 100644
--- a/src/full-codegen/full-codegen.cc
+++ b/src/full-codegen/full-codegen.cc
@@ -66,9 +66,9 @@ bool FullCodeGenerator::MakeCode(CompilationInfo* info) {
code->set_profiler_ticks(0);
code->set_back_edge_table_offset(table_offset);
Handle<ByteArray> source_positions =
- cgen.source_position_table_builder_.ToSourcePositionTable();
+ cgen.source_position_table_builder_.ToSourcePositionTable(
+ isolate, Handle<AbstractCode>::cast(code));
code->set_source_position_table(*source_positions);
- cgen.source_position_table_builder_.EndJitLogging(AbstractCode::cast(*code));
CodeGenerator::PrintCode(code, info);
info->SetCode(code);
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/interpreter/bytecode-array-writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698