src/full-codegen/full-codegen.h - Issue 2248673002: Avoid accessing Isolate in source position logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.h

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.h

diff --git a/src/full-codegen/full-codegen.h b/src/full-codegen/full-codegen.h

index cb2edaf157ea4d08de1d6a510522ea4bc57431e8..71f065b092e521a616153cfea384c1d551ab2e8a 100644

--- a/src/full-codegen/full-codegen.h

+++ b/src/full-codegen/full-codegen.h

@@ -46,7 +46,7 @@ class FullCodeGenerator final : public AstVisitor<FullCodeGenerator> {

info->zone()),

back_edges_(2, info->zone()),

handler_table_(info->zone()),

- source_position_table_builder_(info->isolate(), info->zone(),

+ source_position_table_builder_(info->zone(),

info->SourcePositionRecordingMode()),

ic_total_count_(0) {

DCHECK(!info->IsStub());

« no previous file with comments | « src/debug/liveedit.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »