src/crankshaft/x64/lithium-codegen-x64.cc - Issue 2248673002: Avoid accessing Isolate in source position logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x64/lithium-codegen-x64.cc

diff --git a/src/crankshaft/x64/lithium-codegen-x64.cc b/src/crankshaft/x64/lithium-codegen-x64.cc

index 1ad8ed0ad3a0707b634adc5f8f6a7b2d65d99cf5..e417eaaeb19b729cccd068813c902a5b4d2c90fb 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.cc

+++ b/src/crankshaft/x64/lithium-codegen-x64.cc

@@ -66,9 +66,6 @@ void LCodeGen::FinishCode(Handle<Code> code) {

DCHECK(is_done());

code->set_stack_slots(GetTotalFrameSlotCount());

code->set_safepoint_table_offset(safepoints_.GetCodeOffset());

- Handle<ByteArray> source_positions =

- source_position_table_builder_.ToSourcePositionTable();

- code->set_source_position_table(*source_positions);

PopulateDeoptimizationData(code);

}