[DevTools] Removed wasThrown from evaluate-like protocol methods

[DevTools] Removed wasThrown from evaluate-like protocol methods

I'll remove this flag from frontend in followup.
Clients can emulate wasThrown flag with !!exceptionDetails check.

BUG=635947
R=dgozman@chromium.org

Committed: https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a
Cr-Commit-Position: refs/heads/master@{#411814}

[kozy, 2016-08-10 17:49:23]

Dmitry, please take a look!

[kozy, 2016-08-10 18:38:54]

Description was changed from

==========
[DevTools] Removed wasThrown from evaluate-like protocol methods

I'll remove this flag from frontend in followup.
Clients can emulate wasThrown flag with !!exceptionDetails check.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed wasThrown from evaluate-like protocol methods

I'll remove this flag from frontend in followup.
Clients can emulate wasThrown flag with !!exceptionDetails check.

BUG=635947
R=dgozman@chromium.org
==========

[dgozman, 2016-08-11 01:54:36]

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html
(left):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html:30:
function dispatch(error, result, wasThrown)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html:45:
function storeIdInTargetWindow(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles.html:37:
function dispatch(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart.html:34:
function dispatch(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html:34:
function step1(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html:40:
function step2(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html:46:
function step3(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html:10:
function step1(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html:15:
function step1(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html:27:
function step2(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html:38:
function step1(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html:49:
function step2(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/runtime/runtime-es6-setSymbolPropertyValue.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-es6-setSymbolPropertyValue.html:31:
function step1(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-es6-setSymbolPropertyValue.html:37:
function step2(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties.html:30:
function step1(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties.html:36:
function step2(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html:12:
function step1(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html:44:
function step1(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html:50:
function step2(error, result)
While you are here, let's add exceptionDetails second parameter.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:666: function
evaluatedCallback(error, result, exceptionDetails)
Could you please check why compiler didn't catch missing arguments before?

[kozy, 2016-08-11 21:03:57]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[kozy, 2016-08-11 21:04:22]

All done. Please take a look!

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html
(left):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html:30:
function dispatch(error, result, wasThrown)
On 2016/08/11 01:54:34, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html:45:
function storeIdInTargetWindow(error, result)
On 2016/08/11 01:54:34, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles.html:37:
function dispatch(error, result)
On 2016/08/11 01:54:34, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart.html:34:
function dispatch(error, result)
On 2016/08/11 01:54:34, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html:34:
function step1(error, result)
On 2016/08/11 01:54:34, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html:40:
function step2(error, result)
On 2016/08/11 01:54:34, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html:46:
function step3(error, result)
On 2016/08/11 01:54:34, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html:10:
function step1(error, result)
On 2016/08/11 01:54:34, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html:15:
function step1(error, result)
On 2016/08/11 01:54:35, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html:27:
function step2(error, result)
On 2016/08/11 01:54:35, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html:38:
function step1(error, result)
On 2016/08/11 01:54:35, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html:49:
function step2(error, result)
On 2016/08/11 01:54:35, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/runtime/runtime-es6-setSymbolPropertyValue.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-es6-setSymbolPropertyValue.html:31:
function step1(error, result)
On 2016/08/11 01:54:35, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-es6-setSymbolPropertyValue.html:37:
function step2(error, result)
On 2016/08/11 01:54:35, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties.html:30:
function step1(error, result)
On 2016/08/11 01:54:35, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties.html:36:
function step2(error, result)
On 2016/08/11 01:54:35, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html:12:
function step1(error, result)
On 2016/08/11 01:54:35, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html
(right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html:44:
function step1(error, result)
On 2016/08/11 01:54:36, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html:50:
function step2(error, result)
On 2016/08/11 01:54:35, dgozman wrote:
> While you are here, let's add exceptionDetails second parameter.

Done.

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/2234983002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:666: function
evaluatedCallback(error, result, exceptionDetails)
On 2016/08/11 01:54:36, dgozman wrote:
> Could you please check why compiler didn't catch missing arguments before?

Compiler allows to omit optional arguments in callbacks.

[commit-bot: I haz the power, 2016-08-11 21:06:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 21:34:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 21:34:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kozy, 2016-08-12 00:09:29]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 00:10:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 01:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 01:34:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kozy, 2016-08-12 02:33:23]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 02:33:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 03:15:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 03:15:16]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dgozman, 2016-08-12 04:58:03]

lgtm

[kozy, 2016-08-12 21:47:24]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-08-12 21:48:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 23:26:20]

Description was changed from

==========
[DevTools] Removed wasThrown from evaluate-like protocol methods

I'll remove this flag from frontend in followup.
Clients can emulate wasThrown flag with !!exceptionDetails check.

BUG=635947
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed wasThrown from evaluate-like protocol methods

I'll remove this flag from frontend in followup.
Clients can emulate wasThrown flag with !!exceptionDetails check.

BUG=635947
R=dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-08-12 23:26:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-12 23:35:03]

Description was changed from

==========
[DevTools] Removed wasThrown from evaluate-like protocol methods

I'll remove this flag from frontend in followup.
Clients can emulate wasThrown flag with !!exceptionDetails check.

BUG=635947
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed wasThrown from evaluate-like protocol methods

I'll remove this flag from frontend in followup.
Clients can emulate wasThrown flag with !!exceptionDetails check.

BUG=635947
R=dgozman@chromium.org

Committed: https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a
Cr-Commit-Position: refs/heads/master@{#411814}
==========

[commit-bot: I haz the power, 2016-08-12 23:35:04]

Patchset 4 (id:??) landed as
https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a
Cr-Commit-Position: refs/heads/master@{#411814}