third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html - Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html

index afcff3c484f02830c958ff0712b5a60fac124f31..38fdb71b4a1c1227d20951b1f9fbdb32c21d15bf 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html

@@ -20,9 +20,9 @@ function test()

InspectorTest.addSniffer(panel, "showUISourceCode", showUISourceCodeHook);

WebInspector.context.flavor(WebInspector.ExecutionContext).evaluate("jumpToMe", "", false, true, false, false, false, didGetFunction);

- function didGetFunction(funcObject, wasThrown)

+ function didGetFunction(funcObject, exceptionDetails)

{

- var error = !funcObject || wasThrown;

+ var error = !funcObject || !!exceptionDetails;

InspectorTest.assertTrue(!error);

panel._showFunctionDefinition(funcObject);

}