Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
index c734b2d358a4d0da450010fa2feef3b7083a581c..93f193cae9b7625f447fa0d0b25c33377356ea5f 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
@@ -43,10 +43,10 @@ InspectorTest.evaluateInPage = function(code, callback)
{
callback = InspectorTest.safeWrap(callback);
- function mycallback(error, result, wasThrown)
+ function mycallback(error, result, exceptionDetails)
{
if (!error)
- callback(InspectorTest.runtimeModel.createRemoteObject(result), wasThrown);
+ callback(InspectorTest.runtimeModel.createRemoteObject(result), exceptionDetails);
}
InspectorTest.RuntimeAgent.evaluate(code, "console", false, mycallback);
}
@@ -71,9 +71,9 @@ InspectorTest.evaluateInPageAsync = function(code)
/* awaitPromise */ true,
mycallback);
- function mycallback(error, result, wasThrown, exceptionDetails)
+ function mycallback(error, result, exceptionDetails)
{
- if (!error && !wasThrown) {
+ if (!error && !exceptionDetails) {
callback(InspectorTest.runtimeModel.createRemoteObject(result));
} else {
if (error)

Powered by Google App Engine
This is Rietveld 408576698