third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js - Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html ('k') | third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

index 433b41390379ee0ab8bc9439950e0cce475f6f75..06905974c5017c0c9bfd2489a341f9d04d3a1b4d 100644

--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

@@ -992,15 +992,15 @@ WebInspector.ExtensionServer.prototype = {

/**

* @param {?Protocol.Error} error

* @param {!RuntimeAgent.RemoteObject} result

- * @param {boolean=} wasThrown

+ * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails

- function onEvalute(error, result, wasThrown)

+ function onEvalute(error, result, exceptionDetails)

{

if (error) {

- callback(error, null, wasThrown);

+ callback(error, null, !!exceptionDetails);

return;

}

- callback(error, target.runtimeModel.createRemoteObject(result), wasThrown);

+ callback(error, target.runtimeModel.createRemoteObject(result), !!exceptionDetails);

}